signature now working - #1794
Merged
Merged
Conversation
Contributor
|
@MImran2002 Some checks on GitHub are failing. Or maybe you already saw that? |
BrianRamsay
approved these changes
Aug 24, 2026
BrianRamsay
left a comment
Contributor
There was a problem hiding this comment.
We should make sure the hasGoneToTraining test breaks for the old code and passes for the new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes issue #1791
Changes
attendedis consistently converted from a query into a singleEventParticipantrecord before accessing.event..get()from being called on an already-selectedEventParticipant, which previously caused Peewee to run a new unfiltered query and return the wrong attendance record.attendedremained a query and caused an error when attempting to accessattended.event.Testing
git checkout allVolTrainHotFix.git pulland ensure the branch is up to date../database/reset_database from-backupflask run1). All Volunteer Training only- CELTS Student Handbook + Signature
2). All Volunteer Training and All CELTS Training - CELTS Labor Handbook + Signature
3). All CELTS Training - CELTS Labor Handbook + Signature
4). None - CELTS Labor Handbook + Information to attend event