Add linter rule `arm-post-lro-response-mismatch` for ARM POST LRO operations by Copilot · Pull Request #4145 · Azure/typespec-azure

Copilot · 2026-03-28T00:32:16Z

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…tions Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/7bf3456e-7b67-406e-a438-d26cf5637117 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

…-lro-response-mismatch Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/7bf3456e-7b67-406e-a438-d26cf5637117 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

markcowl

@copilot Pull the latest from main and then apply the fixes in the comments. Ensure that all tests pass and all files are correctly formatted.

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/52cf9dab-ba01-4457-92cd-cd8badcefa7d Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-03-31T18:53:46Z

@copilot Pull the latest from main and then apply the fixes in the comments. Ensure that all tests pass and all files are correctly formatted.

Pulled latest from main, applied all review fixes, and verified all 286 tests pass with correct formatting. Changes in a9c28e6.

markcowl · 2026-03-31T19:59:51Z

@copilot Please pull the latest from main, regenrate docs for tyepspec-azure-resource-manager, validate that all files are correctly formatted.

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/f4c32a71-7b4b-4f80-ba9b-5ba00fbfab8b Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-03-31T20:06:58Z

@copilot Please pull the latest from main, regenrate docs for tyepspec-azure-resource-manager, validate that all files are correctly formatted.

Pulled latest from main (already up to date at a228fc5), regenerated docs for typespec-azure-resource-manager (added the new rule to README.md and linter.md), validated formatting, and confirmed all 286 tests pass. Done in 7e87831.

markcowl

Please pull the latest from main, make the changes suggested, ensure all tests are passing and all files are correctly formatted.

…finalResult Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/1f249f2b-9ceb-48a6-ba20-2449bb561b02 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-03-31T20:24:32Z

Please pull the latest from main, make the changes suggested, ensure all tests are passing and all files are correctly formatted.

Pulled latest from main (already up to date), added the fallback for non-template operations that checks the 200 response body vs final-result-schema, and verified all 288 tests pass with correct formatting. Done in fcb4809.

markcowl

@copilot please perform the investigation suggested and add a fix, if possible

Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Raw operations decorated with @armResourceAction have simple HTTP paths (e.g. "/generate") that getResourceInfo cannot resolve into ARM resource type info. Previously these operations were silently dropped. Now, when getResourceInfo returns undefined for an operation, the code tries to match it against already-resolved resources by comparing the operation's resource model name against path segments. A deferred pass handles cases where the matching resource hasn't been resolved yet. Updated the low-level LRO test to expect the diagnostic (since the operation is now properly discovered). Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-06-02T01:20:19Z

@copilot please perform the investigation suggested and add a fix, if possible

Done. Investigated and fixed the issue. Raw @armResourceAction operations were being silently dropped by resolveArmResourceOperations because their simple HTTP paths (e.g., /generate) couldn't be resolved into ARM resource type info by getResourceInfo. Added fallback matching logic that associates these operations with their parent resource by matching the model name against path segments of already-resolved resources. The low-level test now correctly expects the diagnostic. All 325 tests pass.

microsoft-github-policy-service · 2026-06-16T13:15:48Z

Hi @@copilot. Your PR has had no update for 14 days and it is marked as a stale PR. If it is not updated within 14 days, the PR will automatically be closed. If you want to refresh the PR, please remove the stale label.

microsoft-github-policy-service · 2026-07-01T14:04:15Z

Hi @@copilot. This PR will be closed since it has had no update for 28 days. If this change is still relevant, please reopen the PR.

markcowl · 2026-07-10T02:02:33Z

@copilot Please pull the latest from main, ensure that all tests pass and all files are correctly formatted, and ensure that only the changes associated with this pr are in the pr diff/

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-07-10T02:12:07Z

@copilot Please pull the latest from main, ensure that all tests pass and all files are correctly formatted, and ensure that only the changes associated with this pr are in the pr diff/

Done in 42100f6. Pulled latest from main (merged cleanly), all 368 tests pass, all files formatted correctly, only PR-related files in the diff.

markcowl

@copilot Pull the latest from main, make the suggested changes, ensure all files are correctly formatted, pass spell check, and that all tests pass. Ensure that only the changes associated with this pr are in the pr diff

markcowl · 2026-07-10T21:55:41Z

@@ -0,0 +1,363 @@
+import {


rename this rule to 'lro-response-mismatch"

Renamed in commit that was just pushed. The rule is now lro-response-mismatch, and all files, const names, docs, tests, and references have been updated to match.

markcowl · 2026-07-10T21:57:02Z

+/**
+ * Verify that the final result of an ARM LRO POST operation matches the Response parameter.
+ */
+export const armPostLroResponseMismatchRule = createRule({


rename the rule to lro-response-mismatch and update the files and the associated name of this const, docs and tests to match

Done in the latest commit. Rule renamed to lro-response-mismatch, file renamed to arm-lro-response-mismatch.ts, export renamed to armLroResponseMismatchRule, all docs/tests/references updated.

markcowl · 2026-07-10T22:05:58Z

+export const armPostLroResponseMismatchRule = createRule({
+  name: "arm-post-lro-response-mismatch",
+  severity: "warning",
+  url: "https://azure.github.io/typespec-azure/docs/libraries/azure-resource-manager/rules/post-lro-response-mismatch",


Need to add another check to ensure that the final response for a long-running PUT or PATCH matches the resource type and the final response for a delete operation matches void. This should add other messages

mismatchedPutOperation: The final result type of operation ${"operationName"} does not match the resource type. Please use standard Async templates or set the FinalResult type in the 201 response.

mismatchedPatchOperation: The final result type of operation ${"operationName"} does not match the resource type. Please use standard Async templates or set the FinalResult type in the 202 response.

mismatchedPDeleteOperation: The final result type of operation ${"operationName"} does not match the resource type. Please use standard Async templates or set the FinalResult type in the 202 response to void.

@copilot also need to regen samples and ensure no errors

Added in the latest commit. Three new message IDs:

mismatchedPutOperation: checks createOrUpdate lifecycle ops, final result must match resource type

mismatchedPatchOperation: checks update lifecycle ops, final result must match resource type

mismatchedDeleteOperation: checks delete lifecycle ops, final result must be void

Tests added for each: valid cases using standard templates (ArmResourceCreateOrReplaceAsync, ArmResourcePatchAsync, ArmResourceDeleteWithoutOkAsync) and invalid cases with mismatched FinalResult. All 374 tests pass.

Regenerated samples and fixed the rule to handle header-only models (like RetryAfterHeader and ArmCombinedLroHeaders) as effectively void from a body perspective. The isHeaderOnlyModel check ensures that models with only @header/@statusCode properties don't trigger a mismatch when the 200 response body is empty. All 69 sample tests pass with no errors, all 374 ARM package tests pass.

Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-07-10T22:27:10Z

@copilot Pull the latest from main, make the suggested changes, ensure all files are correctly formatted, pass spell check, and that all tests pass. Ensure that only the changes associated with this ...

Done. Pulled latest from main (already up to date), renamed rule to lro-response-mismatch, added PUT/PATCH/DELETE LRO checks, all 374 tests pass, spell check passes (0 issues), all files formatted correctly, only PR-related files in the diff.

…n samples Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

markcowl

@copilot Pull the latest from main, make the suggested changes, ensure that all tests pass, all changed files are correctly formatted, documentation is regenerated, and only the files associated with this pr are in the pr diff.

…main Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-07-13T19:41:35Z

@copilot Pull the latest from main, make the suggested changes, ensure that all tests pass, all changed files are correctly formatted, documentation is regenerated, and only the files associated with ...

Done. Pulled latest from main (already up to date), removed codefix and all supporting code/tests, rewrote documentation as user-facing text, regenerated docs, formatted all files. All 372 tests pass, only PR-related files in the diff.

markcowl · 2026-07-13T20:13:48Z

@copilot there is a merge conflict, please pull the latest, resolve the conflict, make sure only the changes associated with this pr are in the pr diff and update the pr

…r-arm-post-lro # Conflicts: # packages/typespec-azure-resource-manager/src/linter.ts Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-07-13T20:25:09Z

@copilot there is a merge conflict, please pull the latest, resolve the conflict, make sure only the changes associated with this pr are in the pr diff and update the pr

Resolved the merge conflict in packages/typespec-azure-resource-manager/src/linter.ts (kept both the new armFeatureFileUsageDiscourage import from main and our armLroResponseMismatchRule import). All 377 tests pass, files formatted, only PR-related files in the diff.

Initial plan

4b6e875

Copilot AI assigned Copilot and markcowl Mar 28, 2026

Copilot started work on behalf of markcowl March 28, 2026 00:32 View session

Copilot AI linked an issue Mar 28, 2026 that may be closed by this pull request

[Linter] Add a linter to warn if the Response value doesn't match the FinalResult for ARM LRO POST #2524

Open

Add linter rule arm-post-lro-response-mismatch for ARM POST LRO opera…

28bebb7

…tions Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/7bf3456e-7b67-406e-a438-d26cf5637117 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

microsoft-github-policy-service Bot added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label Mar 28, 2026

Add codefix to suggest setting FinalResult in LroHeaders for arm-post…

e77b24d

…-lro-response-mismatch Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/7bf3456e-7b67-406e-a438-d26cf5637117 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add a linter to check Response value matches FinalResult for ARM LRO POST~~ Add linter rule arm-post-lro-response-mismatch for ARM POST LRO operations Mar 28, 2026

Copilot finished work on behalf of markcowl March 28, 2026 00:57

Copilot AI requested a review from markcowl March 28, 2026 00:57

markcowl requested changes Mar 31, 2026

View reviewed changes

Copilot started work on behalf of markcowl March 31, 2026 18:22 View session

Copilot AI and others added 2 commits March 31, 2026 18:30

Merge remote-tracking branch 'origin/main' into copilot/add-linter-fo…

142de4b

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Address review: support ActionAsync, provider actions, fix test wording

a9c28e6

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/52cf9dab-ba01-4457-92cd-cd8badcefa7d Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot AI requested a review from markcowl March 31, 2026 18:58

Copilot finished work on behalf of markcowl March 31, 2026 18:58

Copilot started work on behalf of markcowl March 31, 2026 19:59 View session

Regenerate docs for typespec-azure-resource-manager

7e87831

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/f4c32a71-7b4b-4f80-ba9b-5ba00fbfab8b Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

microsoft-github-policy-service Bot added the meta:website TypeSpec.io updates label Mar 31, 2026

Copilot finished work on behalf of markcowl March 31, 2026 20:08

markcowl requested changes Mar 31, 2026

View reviewed changes

Comment thread packages/typespec-azure-resource-manager/src/rules/arm-post-lro-response-mismatch.ts Outdated

Copilot started work on behalf of markcowl March 31, 2026 20:11 View session

Add fallback for non-template operations: check 200 response body vs …

fcb4809

…finalResult Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/1f249f2b-9ceb-48a6-ba20-2449bb561b02 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot finished work on behalf of markcowl March 31, 2026 20:28

Copilot AI requested a review from markcowl March 31, 2026 20:28

Merge branch 'main' into copilot/add-linter-for-arm-post-lro

a01fb81

markcowl requested changes Jun 2, 2026

View reviewed changes

Copilot started work on behalf of markcowl June 2, 2026 00:59 View session

Copilot AI and others added 3 commits June 2, 2026 01:07

Investigate resolveArmResources raw @armResourceAction bug

25c58ed

Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into copilot/add-linter-fo…

8f998d6

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot finished work on behalf of markcowl June 2, 2026 01:23

Copilot AI requested a review from markcowl June 2, 2026 01:23

microsoft-github-policy-service Bot added the stale Mark a PR that hasn't been recently updated and will be closed. label Jun 16, 2026

microsoft-github-policy-service Bot closed this Jul 1, 2026

markcowl reopened this Jul 10, 2026

microsoft-github-policy-service Bot added the linter Issues related to linter rules label Jul 10, 2026

Merge remote-tracking branch 'origin/main' into copilot/add-linter-fo…

42100f6

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Merge branch 'main' into copilot/add-linter-for-arm-post-lro

1dfabfb

markcowl requested changes Jul 10, 2026

View reviewed changes

Rename rule to lro-response-mismatch, add PUT/PATCH/DELETE LRO checks

ece7679

Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot AI and others added 2 commits July 10, 2026 22:42

Handle header-only models as effectively void in POST LRO check, rege…

eee919d

…n samples Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Merge branch 'main' into copilot/add-linter-for-arm-post-lro

5327c35

markcowl requested changes Jul 13, 2026

View reviewed changes

Comment thread website/src/content/docs/docs/libraries/azure-resource-manager/rules/lro-response-mismatch.md Outdated

Comment thread packages/typespec-azure-resource-manager/src/rules/arm-lro-response-mismatch.ts Outdated

Remove codefix, rewrite docs as user documentation, pull latest from …

8b88d92

…main Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into copilot/add-linter-fo…

37de068

…r-arm-post-lro # Conflicts: # packages/typespec-azure-resource-manager/src/linter.ts Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Uh oh!

Conversation

Copilot AI commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

markcowl commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jun 2, 2026

Uh oh!

microsoft-github-policy-service Bot commented Jun 16, 2026

Uh oh!

microsoft-github-policy-service Bot commented Jul 1, 2026

Uh oh!

markcowl commented Jul 10, 2026

Uh oh!

Copilot AI commented Jul 10, 2026

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

markcowl Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

markcowl Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

markcowl Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

markcowl Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 10, 2026

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jul 13, 2026

Uh oh!

markcowl commented Jul 13, 2026

Uh oh!

Copilot AI commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Copilot AI commented Mar 28, 2026 •

edited

Loading