[AzureServiceFabric provider] Fix net48 test assembly binding issues and HttpClient mock#1370
Merged
shankarsama merged 1 commit intoJun 19, 2026
Conversation
shankarsama
commented
Jun 19, 2026
shankarsama
commented
Member
- Add binding redirects for revision-number mismatches in both SF test projects (Microsoft.Extensions.Logging.Abstractions, System.Diagnostics.DiagnosticSource, System.Memory, System.Threading.Tasks.Extensions, Castle.Core, Newtonsoft.Json)
- Fix HttpClient mock in FunctionalTests: mock HttpMessageHandler.SendAsync instead of non-virtual HttpClient.PutAsync
- Add AzureServiceFabricTests.md with local test setup instructions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets improved reliability for the Azure Service Fabric provider’s net48 test runs by addressing assembly binding redirect issues, correcting the HttpClient mocking approach in an integration test, and documenting local test setup steps.
Changes:
- Adds/updates binding redirects intended to resolve net48 assembly version/revision mismatches in Service Fabric test projects.
- Fixes an integration test to mock
HttpMessageHandler.SendAsync(instead of non-virtualHttpClientmethods). - Adds local execution documentation for Service Fabric unit + integration tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Test/DurableTask.AzureServiceFabric.Tests/App.config | Adds binding redirects (but currently under legacy Test/ tree, not the active solution test project). |
| test/DurableTask.AzureServiceFabric.Integration.Tests/FunctionalTests.cs | Updates HttpClient mocking to use HttpMessageHandler + Moq.Protected. |
| test/DurableTask.AzureServiceFabric.Integration.Tests/App.config | Adds additional binding redirects for net48 integration tests. |
| Test/AzureServiceFabricTests.md | Adds documentation for running Service Fabric tests locally. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add binding redirects for revision-number mismatches in both SF test projects (Microsoft.Extensions.Logging.Abstractions, System.Diagnostics.DiagnosticSource, System.Memory, System.Threading.Tasks.Extensions, Castle.Core, Newtonsoft.Json) - Fix HttpClient mock in FunctionalTests: mock HttpMessageHandler.SendAsync instead of non-virtual HttpClient.PutAsync - Add AzureServiceFabricTests.md with local test setup instructions - Update Newtonsoft.Json redirect to 13.0.0.0 (matching Directory.Packages.props) - Place all new files under active test/ directory (not legacy Test/) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
shankarsama
force-pushed
the
servicefabric-fix-net48-test-bindings
branch
from
00f4b72 to
054bd5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.