Skip to content

Sync eng/common directory with azure-sdk-tools for PR 17643 - #50106

Open
azure-sdk-automation[bot] wants to merge 3 commits into
mainfrom
sync-eng-common-copilot/update-new-testresources-default-17643
Open

azure-sdk-automation[bot] wants to merge 3 commits into
mainfrom
sync-eng-common-copilot/update-new-testresources-default-17643

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17643 See eng/common workflow

@azure-sdk-automation
azure-sdk-automation Bot requested review from Heath Stewart (heaths) and a balanced review from Copilot November 21, 2026 01:08
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Nov 21, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Example 1 omits -SubscriptionId in the documentation and script help, causing the new default to target TME instead of the custom subscription selected by Connect-AzAccount.

1 open issue
What changed in this PR

Syncs shared test-resource tooling from azure-sdk-tools PR #17643, changing the default interactive provisioning target to the Azure SDK Test Resources - TME subscription.

Changes:

  • Signs in to the TME tenant when needed and attempts to select its test subscription when -SubscriptionId is omitted.
  • Corrects the subscription variable name used for selection and restoration.
  • Documents the new default and how to select another subscription.
File Description
eng/​common/​TestResources/​New-TestResources.ps1.md Documents the TME default and explicit subscription override.
eng/​common/​TestResources/​New-TestResources.ps1 Updates default authentication and subscription selection; fixes subscription variable naming.

Review effort: Balanced

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@azure-sdk-automation
azure-sdk-automation Bot force-pushed the sync-eng-common-copilot/update-new-testresources-default-17643 branch from e71916b to 477c613 Compare November 21, 2026 01:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants