Repository navigation
[AutoPR azure-mgmt-consumption]-generated-from-SDK Generation - Python-6707979 - #48597
azure-sdk-automation[bot] wants to merge 4 commits into
Conversation
….Consumption/Consumption/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: 'c724dc9c81b1ab37190c0f56b0354b2d63980710' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6705668 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the azure-mgmt-consumption Python SDK generation to the 2026-06-01 Consumption RP API version, adding management-group scoped reservation recommendation support and refreshing generated artifacts.
Changes:
- Bump default API version to
2026-06-01across request builders, metadata, and samples. - Add support for
ManagementGrouprecommendation scope (new enum member/models + newmanagement_group_idparameter onReservationRecommendationDetailsOperations.get). - Introduce an API-version gating decorator (
api_version_validation) and update generated API surface/docs/versioning.
Reviewed changes
Copilot reviewed 128 out of 128 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/consumption/azure-mgmt-consumption/tsp-location.yaml | Updates source commit pointer for swagger/typespec input. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_for_billing_period_by_management_group.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_for_billing_period_by_enrollment_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_for_billing_period_by_department.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_for_billing_period_by_billing_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_for_billing_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_filter_by_tag.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_metric_usage.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_metric_amortized_cost.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_metric_actual_cost.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_mca_invoice_section.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_mca_customer.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_mca_billing_profile.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_mca_billing_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_management_group.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_enrollment_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_department.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list_by_billing_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_list.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/usage_details_expand.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/tags.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_transactions_list_by_enrollment_number.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_transactions_list_by_billing_profile_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_summaries_monthly_with_reservation_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_summaries_monthly_with_billing_profile_id_reservation_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_summaries_monthly_with_billing_profile_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_summaries_monthly_with_billing_account_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_summaries_monthly.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_summaries_daily_with_reservation_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_summaries_daily_with_billing_profile_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_summaries_daily_with_billing_account_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_summaries_daily.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendations_filter_by_subscription_for_scope_look_back_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendations_by_subscription.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendations_by_resource_group.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendations_by_billing_profile.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendations_by_billing_account_for_management_group.py | Adds new generated sample for management-group related reservation recommendations. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendations_by_billing_account_filter_by_scope.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendations_by_billing_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendation_details_pre_purchase_plan_by_subscription.py | Adds new generated sample for pre-purchase plan details. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendation_details_by_subscription.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendation_details_by_resource_group.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendation_details_by_billing_profile.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendation_details_by_billing_account_for_management_group.py | Adds new generated sample for management-group scoped recommendation details. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendation_details_by_billing_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_details_with_reservation_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_details_by_billing_profile_id_reservation_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_details_by_billing_profile_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_details_by_billing_account_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_details.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/price_sheet_for_billing_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/price_sheet_expand.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/price_sheet.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/operation_list.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_list_for_billing_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_list.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_by_management_group_list_for_billing_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_by_management_group_list.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_by_enrollment_accounts_list_by_billing_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_by_enrollment_account_list.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_by_department_list_by_billing_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_by_department_list.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_by_billing_account_list_for_billing_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/marketplaces_by_billing_account_list.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/lots_list_by_customer_with_filters.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/lots_list_by_customer.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/lots_list_by_billing_profile.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/lots_list_by_billing_account_with_filters_primary.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/lots_list_by_billing_account_with_filters_contributor.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/lots_list_by_billing_account_with_filters.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/lots_list_by_billing_account_primary.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/lots_list_by_billing_account_contributor.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/lots_list_by_billing_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/events_list_by_billing_profile.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/events_get_by_billing_account_with_filters_primary.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/events_get_by_billing_account_with_filters_contributor.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/events_get_by_billing_account_with_filters.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/events_get_by_billing_account_primary.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/events_get_by_billing_account_contributor.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/events_get_by_billing_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/ea_price_sheet_for_billing_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/delete_budget.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/credit_summary_by_billing_profile.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/create_or_update_budget.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_for_enrollment_account_filter_by_start_end_date.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_for_department_filter_by_start_end_date.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_by_modern_invoice_section_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_by_modern_customer.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_by_modern_billing_profile_invoice_section.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_by_modern_billing_profile_group_by_invoice_section_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_by_modern_billing_profile.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_by_modern_billing_account_group_by_invoice_section_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_by_modern_billing_account_group_by_customer_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_by_modern_billing_account_group_by_billing_profile_id.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_list_by_modern_billing_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_for_billing_period_by_enrollment_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/charges_for_billing_period_by_department.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/budgets_list.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/budget.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/balances_by_billing_account_for_billing_period.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/balances_by_billing_account.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/aggregated_cost_for_billing_period_by_management_group.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/aggregated_cost_by_management_group_filter_by_date.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/generated_samples/aggregated_cost_by_management_group.py | Updates x-ms-original-file reference to 2026-06-01. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/types.py | Updates public TypedDict field names and docstrings to new naming. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/operations/_patch.py | Removes stray whitespace in patch file. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/operations/_operations.py | Bumps default API version; adds management_group_id + API version validation decorator; extends scope docs. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/models/_patch.py | Removes stray whitespace in patch file. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/models/_models.py | Adds management-group scoped models and projected-usage properties; updates flattened items and suppressions. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/models/_enums.py | Adds Scope.MANAGEMENT_GROUP. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/models/init.py | Exports newly added models. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/aio/operations/_patch.py | Removes stray whitespace in patch file. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/aio/operations/_operations.py | Adds async API version validation decorator and management_group_id parameter; updates suppressions. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/aio/_patch.py | Removes stray whitespace in patch file. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/aio/_configuration.py | Bumps default API version and updates config docstring + pylint disables. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/aio/_client.py | Updates api_version docstring + pylint disables. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_version.py | Bumps library version to 11.1.0. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_validation.py | Adds API version gating decorator used on operations. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_utils/serialization.py | Expands serializer docstring to document constructor params. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_utils/model_base.py | Enhances JSON encoder docs; adds bool-from-string deserializer support. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_patch.py | Removes stray whitespace in patch file. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_configuration.py | Bumps default API version and updates config docstring + pylint disables. |
| sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_client.py | Updates api_version docstring + pylint disables. |
| sdk/consumption/azure-mgmt-consumption/apiview-properties.json | Updates APIView mappings and cross-language version hash for new surface area. |
| sdk/consumption/azure-mgmt-consumption/api.metadata.yml | Updates parser version and content hash for API MD. |
| sdk/consumption/azure-mgmt-consumption/api.md | Updates API surface doc for new models/params and renamed TypedDict keys. |
| sdk/consumption/azure-mgmt-consumption/_metadata.json | Updates tracked API version/commit and emitter/http client versions. |
| sdk/consumption/azure-mgmt-consumption/CHANGELOG.md | Adds release notes for 11.1.0 describing new features. |
Suppressed comments (1)
sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendation_details_by_billing_account_for_management_group.py:1
- This new sample calls
reservation_recommendation_details.getwithscope=\"ManagementGroup\"but does not passmanagement_group_id. The operation docstring states this value is required for ManagementGroup scope, so the sample is likely to fail at runtime. Addmanagement_group_id=\"<management-group-id>\"(or the appropriate placeholder) to the call.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This comment has been minimized.
This comment has been minimized.
….Consumption/Consumption/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '069ddc2a68bac3f5e5f51a9e3c4636a5316cade3' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6707979 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 128 out of 128 changed files in this pull request and generated 2 comments.
Suppressed comments (3)
sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendation_details_by_billing_account_for_management_group.py:1
- This sample sets
scope=\"ManagementGroup\"but does not passmanagement_group_id, even though the generated operation docstring indicates it is required for management-group scope. Update the sample call to includemanagement_group_id(and use a realistic management group ID value) so the sample can run successfully.
sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_validation.py:62 - The API-version gating logic can produce incorrect rejections in two concrete cases: (1) if
client_api_versionisn't present inapi_versions_list(e.g., a newer service date string),_index_with_defaultreturns-1and the wrapper treats it as older than everything; and (2) parameters are treated as 'used' solely by presence inkwargs, so callers passingmanagement_group_id=Noneexplicitly can be rejected even though it won't be sent. Consider (a) comparing API versions by parsing theYYYY-MM-DDstrings (or falling back to string/date comparison) when list lookup fails, and (b) only flagging a parameter whenkwargs.get(parameter) is not None.
def _index_with_default(value: str, default: int = -1) -> int:
"""Get the index of value in lst, or return default if not found.
:param value: The value to search for in the api_versions_list.
:type value: str
:param default: The default value to return if the value is not found.
:type default: int
:return: The index of the value in the list, or the default value if not found.
:rtype: int
"""
try:
return api_versions_list.index(value)
except ValueError:
return default
def decorator(func):
@functools.wraps(func)
def wrapper(*args, **kwargs):
try:
# this assumes the client has an _api_version attribute
client = args[0]
client_api_version = client._config.api_version # pylint: disable=protected-access
except AttributeError:
return func(*args, **kwargs)
if _index_with_default(method_added_on) > _index_with_default(client_api_version):
raise ValueError(
f"'{func.__name__}' is not available in API version "
f"{client_api_version}. Pass service API version {method_added_on} or newer to your client."
)
unsupported = {
parameter: api_version
for api_version, parameters in params_added_on.items()
for parameter in parameters
if parameter in kwargs and _index_with_default(api_version) > _index_with_default(client_api_version)
}
if unsupported:
raise ValueError(
"".join(
[
f"'{param}' is not available in API version {client_api_version}. "
f"Use service API version {version} or newer.\n"
for param, version in unsupported.items()
]
)
)
return func(*args, **kwargs)
sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_utils/model_base.py:356
_deserialize_bool_as_strassumesattris a string when it's not already a bool. IfattrisNoneor any non-string type, this will raise at runtime. Make this deserializer tolerant by checkingisinstance(attr, str)(and handlingNoneby returningNone), and consider normalizing whitespace/casing safely.
def _deserialize_bool_as_str(attr):
if isinstance(attr, bool):
return attr
return attr.lower() == "true"
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 128 out of 128 changed files in this pull request and generated 3 comments.
Suppressed comments (3)
sdk/consumption/azure-mgmt-consumption/generated_samples/reservation_recommendation_details_by_billing_account_for_management_group.py:1
- This sample calls
reservation_recommendation_details.getwithscope=\"ManagementGroup\"but does not passmanagement_group_id, which the method docstring indicates is required for ManagementGroup scope. The sample should include themanagement_group_idargument so it can run successfully against the service.
sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_validation.py:50 - The validator treats a parameter as 'used' if it exists in
kwargs, even when the caller explicitly passesNone(or passes through a defaulted variable). This can raise aValueErrorfor an API-version-gated parameter even though it is effectively not set. Consider checking bothparameter in kwargsandkwargs.get(parameter) is not None(or an equivalent sentinel-based check) before flagging it as unsupported.
unsupported = {
parameter: api_version
for api_version, parameters in params_added_on.items()
for parameter in parameters
if parameter in kwargs and _index_with_default(api_version) > _index_with_default(client_api_version)
}
sdk/consumption/azure-mgmt-consumption/azure/mgmt/consumption/_utils/model_base.py:356
_deserialize_bool_as_strwill raise anAttributeErrorifattris neitherboolnorstr(e.g., an int,None, etc.). Since this is a generic deserializer path, it should defensively handle non-string inputs (e.g.,isinstance(attr, str)before calling.lower()) and either returnattrunchanged, coerce known alternative representations, or raise a clearerValueError.
def _deserialize_bool_as_str(attr):
if isinstance(attr, bool):
return attr
return attr.lower() == "true"
[Pilot] PR Pipeline Failure AnalysisA CI pipeline failed on this pull request. Here is an automated analysis of what went wrong and how to get the build green. What failedThe python - pullrequest pipeline (Build #6707986) failed on the Build_Windows job due to two infrastructure-related issues:
Both failures appear to be infrastructure in nature (service outage + agent setup failure), not caused by code changes in this PR. Recommended next steps
Raw pipeline analysis (azsdk ci analyze)
|
|
Hi Madhumitha Raveendar (@madhuravee27), we have approved the PR. You can move on to merge and release though the action suggestion in Release Plan. |
Management SDK PR reviewFindings: None. Unverified checksUnverified checks: None. Review summaryReviewed package
No other files under |
|
Hi @azure-sdk-automation[bot]. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Configurations: 'specification/consumption/resource-manager/Microsoft.Consumption/Consumption/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '069ddc2a68bac3f5e5f51a9e3c4636a5316cade3' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6707979 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36087 Submitted by: mraveendar@microsoft.com