Route top-level docs through lightweight PR validation - #50386
Open
vcolin7 wants to merge 10 commits into
Open
Conversation
vcolin7
requested review from
a team,
Ben Broderick Phillips (benbp),
Mike Harder (mikeharder) and
Ray Chen (raych1)
as code owners
September 9, 2026 06:55
|
Azure Pipelines: 36 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
vcolin7
added this pull request to stack #50387
September 9, 2026 06:56
Expand link validation to every Java PR target branch, remove the duplicate Analyze spelling step, and exclude only docs/** from the Azure PR pipeline. Keep root and package documentation on the existing classifier path.
vcolin7
force-pushed
the
vcolin7/exclude-static-docs-paths
branch
from
September 9, 2026 06:59
1b67a9f to
c708870
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The trigger/exclusion changes are narrowly scoped, aligned across pipelines/workflows, and backed by targeted Pester tests that enforce the intended contracts.
Pull request overview
This PR routes docs/**-only pull requests away from the heavyweight Azure Pipelines java - pullrequest validation and through lightweight GitHub Actions checks (spelling + link verification), while keeping mixed PR behavior stable via explicit classifier exclusions and regression tests.
Changes:
- Excludes
docs/**-only changes from the Azure Pipelines PR trigger and also excludesdocs/from package selection for mixed PRs. - Expands the Verify Links GitHub Actions workflow branch filters to match the
java - pullrequesttarget branches. - Removes the duplicate CSpell step from the Azure Pipelines Analyze job and adds Pester tests to enforce branch parity and exclusion contracts.
File summaries
| File | Description |
|---|---|
| eng/scripts/tests/PullRequest-Trigger.tests.ps1 | Adds Pester coverage to lock in PR trigger exclusions, workflow branch parity, and reviewed docs/** file-type invariants. |
| eng/pipelines/templates/jobs/ci.yml | Removes the duplicated Azure Pipelines spelling step from Analyze (spelling is now handled via a dedicated GitHub Actions workflow). |
| eng/pipelines/pullrequest.yml | Excludes docs/** from the PR trigger and adds docs/ to ExcludePaths to keep docs out of mixed-PR package selection. |
| .github/workflows/verify-links.yml | Aligns workflow PR branch filters with the Azure Pipelines java - pullrequest branch set. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
vcolin7
requested review from
a team,
amber-yujueWang,
Paul Hsu (bojunehsu),
Changjian Wang (changjian-wang),
Chien Yuan Chang (chienyuanchang),
emilyjiji,
Kiran Kumar Kolli (kirankumarkolli),
pankopon,
Ryan Hurey (rhurey),
xitzhang (xitzhang) and
Yung-Shin Lin (yungshinlintw)
as code owners
September 9, 2026 22:39
…c-docs-paths # Conflicts: # .github/workflows/check-spelling.yml
Member
Author
|
We can go ahead with this PR. We recently enabled the Check Spelling GitHub action as a required check, as shown in this draft PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
docs/**fromjava - pullrequest.docs/out of package selection for mixed PRs.restapi*andpipelinev3*target branch patterns.docs/**file types.Motivation
PR #50302 prevents documentation-only changes from creating Java test matrices, but Build and Analyze still run.
PR #50383 added independent spelling validation. This change routes the top-level
docs/**tree through that required lightweight check so those changes can avoid the Java pipeline entirely.Validation
git diff --checkpassed.eng/commonchanges or centrally synchronized workflow changes.Rollout
The rollout prerequisites are complete:
Check Spellingis required by the repository ruleset.Scope
This change excludes only
docs/**.Root documentation and legal files remain on the existing classifier path because exact-file
ExcludePathsmatching requires an upstreamAzure/azure-sdk-toolschange. Package README, CHANGELOG, SAMPLE, and TROUBLESHOOTING files also remain on the classifier path.The centrally synchronized Verify Links workflow remains unchanged. No blanket Markdown or text-file exclusions are added.
Written with the help of vcolin7-copilot.