[AutoPR azure-resourcemanager-elastic]-generated-from-SDK Generation - Java-6798297 - #50377
Open
azure-sdk-automation[bot] wants to merge 1 commit into
Open
azure-sdk-automation[bot] wants to merge 1 commit into
azure-sdk-automation[bot] wants to merge 1 commit into
Conversation
…stic/Elastic/tspconfig.yaml', and CommitSHA: 'f398d14cf518231c3512b317db36c431794d1a83' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6798073 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
azure-sdk-automation
Bot
requested review from
a team,
Arthur Ma (ArthurMa1978),
Xiaofei Cao (XiaofeiCao),
Haoling Dong (haolingdong-msft) and
Weidong Xu (weidongxu-microsoft)
as code owners
September 8, 2026 08:23
azure-sdk-automation
Bot
added
the
auto-release
github-actions
Bot
added
the
Mgmt
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
There are actionable issues in the updated public API ergonomics/backward-compatibility surface and the current CHANGELOG header format should be corrected before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This AutoPR updates the azure-resourcemanager-elastic management library to a newer Swagger/TypeSpec source (spec repo commit f398d14c…) and refreshes the SDK to target API version 2026-03-15-preview, including updated delete APIs that support a new softDelete query parameter.
Changes:
- Updated spec input tracking (
tsp-location.yaml) and bumped API version to2026-03-15-previewacross client, metadata, docs, and samples. - Updated
Monitorsdelete operations to acceptsoftDeleteand refreshed corresponding client/implementation plumbing. - Updated package version and release notes for
1.3.0-beta.1.
File summaries
| File | Description |
|---|---|
| sdk/elastic/azure-resourcemanager-elastic/tsp-location.yaml | Points generation to the new spec directory and commit SHA. |
| sdk/elastic/azure-resourcemanager-elastic/src/test/java/com/azure/resourcemanager/elastic/generated/MonitorsDeleteMockTests.java | Generated test updated to call the new delete signature with softDelete. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/VMIngestionDetailsSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/VMHostListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/VMCollectionUpdateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/UpgradableVersionsDetailsSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/TrafficFiltersDeleteSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/TagRulesListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/TagRulesGetSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/TagRulesDeleteSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/TagRulesCreateOrUpdateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/OrganizationsResubscribeSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/OrganizationsGetElasticToAzureSubscriptionMappingSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/OrganizationsGetApiKeySamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/OperationsListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/OpenAIListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/OpenAIGetStatusSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/OpenAIGetSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/OpenAIDeleteSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/OpenAICreateOrUpdateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitorsUpdateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitorsListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitorsListByResourceGroupSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitorsGetByResourceGroupSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitorsDeleteSamples.java | Generated sample updated to include softDelete usage and a soft-delete variant. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitorsCreateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitorOperationUpgradeSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitoredSubscriptionsUpdateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitoredSubscriptionsListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitoredSubscriptionsGetSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitoredSubscriptionsDeleteSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitoredSubscriptionsCreateorUpdateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/MonitoredResourcesListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/ListAssociatedTrafficFiltersListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/ExternalUserCreateOrUpdateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/ElasticVersionsListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/DetachTrafficFilterUpdateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/DetachAndDeleteTrafficFilterDeleteSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/DeploymentInfoListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/CreateAndAssociatePLFilterCreateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/CreateAndAssociateIpFiltersCreateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/ConnectedPartnerResourcesListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/BillingInfoGetSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/AssociateTrafficFilterAssociateSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/samples/java/com/azure/resourcemanager/elastic/generated/AllTrafficFiltersListSamples.java | Generated sample metadata updated to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/main/resources/META-INF/azure-resourcemanager-elastic_metadata.json | Updates apiVersions to preview and refreshes cross-language metadata fields. |
| sdk/elastic/azure-resourcemanager-elastic/src/main/java/com/azure/resourcemanager/elastic/models/Monitors.java | Public API updated: introduces softDelete parameter and adjusts delete method set. |
| sdk/elastic/azure-resourcemanager-elastic/src/main/java/com/azure/resourcemanager/elastic/implementation/MonitorsImpl.java | Wires softDelete through delete-by-id variants and updates delete method names/signatures. |
| sdk/elastic/azure-resourcemanager-elastic/src/main/java/com/azure/resourcemanager/elastic/implementation/MonitorsClientImpl.java | Adds softDelete query param to REST calls and extends delete LRO flow to accept it. |
| sdk/elastic/azure-resourcemanager-elastic/src/main/java/com/azure/resourcemanager/elastic/implementation/ElasticManagementClientImpl.java | Updates default API version constant to 2026-03-15-preview. |
| sdk/elastic/azure-resourcemanager-elastic/src/main/java/com/azure/resourcemanager/elastic/fluent/MonitorsClient.java | Fluent client delete/beginDelete signatures updated to accept softDelete. |
| sdk/elastic/azure-resourcemanager-elastic/SAMPLE.md | Refreshes embedded sample snippets to 2026-03-15-preview and new delete signature. |
| sdk/elastic/azure-resourcemanager-elastic/README.md | Updates stated API version and dependency snippet version to 1.3.0-beta.1. |
| sdk/elastic/azure-resourcemanager-elastic/pom.xml | Updates package description API version (version already 1.3.0-beta.1). |
| sdk/elastic/azure-resourcemanager-elastic/CHANGELOG.md | Records the new preview API version and notes breaking changes/features for Monitors. |
Review details
Suppressed comments (1)
sdk/elastic/azure-resourcemanager-elastic/src/main/java/com/azure/resourcemanager/elastic/models/Monitors.java:167
deleteByIdWithResponsenow requires asoftDeleteargument, which similarly forces callers to passnullwhen they only need aContextand removes the priordeleteByIdWithResponse(String, Context)signature. Consider reintroducing that overload (delegating to this method withsoftDelete = null) to keep the API convenient and source-compatible.
* @throws IllegalArgumentException thrown if parameters fail the validation.
* @throws com.azure.core.management.exception.ManagementException thrown if the request is rejected by server.
* @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
*/
void deleteByIdWithResponse(String id, Boolean softDelete, Context context);
- Files reviewed: 11/55 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
Automated management AutoPR review
Informational
|
azure-sdk-automation
Bot
changed the title
Weidong Xu (weidongxu-microsoft)
force-pushed
the
sdkauto/azure-resourcemanager-elastic-6798073
branch
from
September 8, 2026 10:28
5ac8fcf to
417474f
Compare
Weidong Xu (weidongxu-microsoft)
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/elastic/resource-manager/Microsoft.Elastic/Elastic/tspconfig.yaml', and CommitSHA: '3c5c630d8117362d6e36522350602e39dfabca70' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6798297 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36441 Submitted by: Pooja.Shetty@microsoft.com