Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/common/TestResources/New-TestResources.ps1.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ Limit $BaseName to enough characters to be under limit plus prefixes specified i
the ARM template.
See also https://docs.microsoft.com/azure/architecture/best-practices/resource-naming

Note: The value specified for this parameter will be overriden and generated
Note: The value specified for this parameter will be overridden and generated
by New-TestResources.ps1 if $CI is specified.

```yaml
Expand Down
2 changes: 1 addition & 1 deletion sdk/clientcore/core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ implementation.

### Accessing HTTP Response Details Using `Response<T>`

_Service clients_ have methods that call Core services, we refer call these methods _service methods_.
_Service clients_ have methods that call Core services, we call these methods _service methods_.

_Service methods_ can return a shared Core type `Response<T>`. This type provides access to both the deserialized result
of the service call and to the details of the HTTP response returned from the server.
Expand Down
6 changes: 3 additions & 3 deletions sdk/core/azure-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ These will be introduced by way of the examples presented below.

### Accessing HTTP Response Details Using `Response<T>`

_Service clients_ have methods that call Azure services, we refer call these methods _service methods_.
_Service clients_ have methods that call Azure services, we call these methods _service methods_.

_Service methods_ can return a shared Azure Core type `Response<T>`. This type provides access to both the
deserialized result of the service call and to the details of the HTTP response returned from the server.
Expand All @@ -106,12 +106,12 @@ sequentially to prepare it being sent by an `HttpClient`.

### Pagination with `ContinuablePagedFlux<T>`

`ContinuablePageFlux` manages sending an initial page request to a service and retrieving additional pages as the
`ContinuablePagedFlux` manages sending an initial page request to a service and retrieving additional pages as the
consumer requests more data until the consumer finishes processing or all pages have been consumed.

### Long Running Operations with `PollerFlux<T>`

`PollerFlux` manages sending an initial service request and requesting processing updates on a fix interval until
`PollerFlux` manages sending an initial service request and requesting processing updates on a fixed interval until
polling is cancelled or reaches a terminal state.

### Configuring Builders
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public String toString() {
}

/**
* Checks if the {@code eTag} a valid ETag value. Valid ETags show below,
* Checks if the {@code eTag} is a valid ETag value. Valid ETags show below,
* - The special character, '*'.
* - A strong ETag, which the value is wrapped in quotes, ex, "12345".
* - A weak ETag, which value is wrapped in quotes and prefixed by "W/", ex, W/"12345".
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ private ProgressReporter(ProgressListener progressListener) {
}

/**
* Creates child {@link ProgressReporter}. It tracks it's own progress and reports to parent.
* Creates child {@link ProgressReporter}. It tracks its own progress and reports to parent.
* @param parent The parent {@link ProgressReporter}. Must not be null.
*/
private ProgressReporter(ProgressReporter parent) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1489,14 +1489,14 @@ private Mono<CosmosBatchResponse> executeCosmosBatchHelper(CosmosBatch encrypted
* @param <TContext> The context for the bulk processing.
* @param operations Flux of operation which will be executed by this container.
*
* @return A Flux of {@link CosmosBulkOperationResponse} which contains operation and it's response or exception.
* @return A Flux of {@link CosmosBulkOperationResponse} which contains operation and its response or exception.
* <p>
* To create a operation which can be executed here, use {@link com.azure.cosmos.models.CosmosBulkOperations}. For eg.
* for a upsert operation use {@link com.azure.cosmos.models.CosmosBulkOperations#getUpsertItemOperation(Object, PartitionKey)}
* </p>
* <p>
* We can get the corresponding operation using {@link CosmosBulkOperationResponse#getOperation()} and
* it's response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* its response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* successfully, the value returned by {@link com.azure.cosmos.models.CosmosBulkItemResponse#isSuccessStatusCode()} will be true. To get
* actual status use {@link com.azure.cosmos.models.CosmosBulkItemResponse#getStatusCode()}.
* </p>
Expand Down Expand Up @@ -1541,14 +1541,14 @@ private static String getIdValue(CosmosItemOperation itemOperation)
* @param bulkOptions Options that apply for this Bulk request which specifies options regarding execution like
* concurrency, batching size, interval and context.
*
* @return A Flux of {@link CosmosBulkOperationResponse} which contains operation and it's response or exception.
* @return A Flux of {@link CosmosBulkOperationResponse} which contains operation and its response or exception.
* <p>
* To create a operation which can be executed here, use {@link com.azure.cosmos.models.CosmosBulkOperations}. For eg.
* for a upsert operation use {@link com.azure.cosmos.models.CosmosBulkOperations#getUpsertItemOperation(Object, PartitionKey)}
* </p>
* <p>
* We can get the corresponding operation using {@link CosmosBulkOperationResponse#getOperation()} and
* it's response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* its response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* successfully, the value returned by {@link com.azure.cosmos.models.CosmosBulkItemResponse#isSuccessStatusCode()} will be true. To get
* actual status use {@link com.azure.cosmos.models.CosmosBulkItemResponse#getStatusCode()}.
* </p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -386,14 +386,14 @@ public <T> CosmosItemResponse<T> patchItem(
* @param <TContext> The context for the bulk processing.
* @param operations list of operation which will be executed by this container.
*
* @return An Iterable of {@link CosmosBulkOperationResponse} which contains operation and it's response or exception.
* @return An Iterable of {@link CosmosBulkOperationResponse} which contains operation and its response or exception.
* <p>
* To create a operation which can be executed here, use {@link com.azure.cosmos.models.CosmosBulkOperations}. For eg.
* for a upsert operation use {@link com.azure.cosmos.models.CosmosBulkOperations#getUpsertItemOperation(Object, PartitionKey)}
* </p>
* <p>
* We can get the corresponding operation using {@link CosmosBulkOperationResponse#getOperation()} and
* it's response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* its response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* successfully, the value returned by {@link com.azure.cosmos.models.CosmosBulkItemResponse#isSuccessStatusCode()} will be true. To get
* actual status use {@link com.azure.cosmos.models.CosmosBulkItemResponse#getStatusCode()}.
* </p>
Expand All @@ -414,14 +414,14 @@ public <TContext> Iterable<CosmosBulkOperationResponse<TContext>> executeBulkOpe
* @param bulkOptions Options that apply for this Bulk request which specifies options regarding execution like
* concurrency, batching size, interval and context.
*
* @return An Iterable of {@link CosmosBulkOperationResponse} which contains operation and it's response or exception.
* @return An Iterable of {@link CosmosBulkOperationResponse} which contains operation and its response or exception.
* <p>
* To create a operation which can be executed here, use {@link com.azure.cosmos.models.CosmosBulkOperations}. For eg.
* for a upsert operation use {@link com.azure.cosmos.models.CosmosBulkOperations#getUpsertItemOperation(Object, PartitionKey)}
* </p>
* <p>
* We can get the corresponding operation using {@link CosmosBulkOperationResponse#getOperation()} and
* it's response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* its response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* successfully, the value returned by {@link com.azure.cosmos.models.CosmosBulkItemResponse#isSuccessStatusCode()} will be true. To get
* actual status use {@link com.azure.cosmos.models.CosmosBulkItemResponse#getStatusCode()}.
* </p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ protected Object[][] getContents() {
{"R_UnexpectedSourceType", "Unexpected source data type: {0}."},
{"R_UnexpectedTargetType", "Unexpected target data type: {0}."},
{"R_InvalidTemporalValue", "Invalid temporal value provided."},
{"R_KeystoreProviderError", "An error has occured while getting keystore provider."},
{"R_KeystoreProviderError", "An error has occurred while getting keystore provider."},
{"R_CannotBeNull", "{0} cannot be null."}, {"R_CannotBeNullOrWhiteSpace", "{0} cannot be null or empty or consist of only whitespace. "},
{"R_InvalidPSLength",
"Value ''{0}'' of type {1} is invalid for the expected precision of {2} and scale of {3}."},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ public void split_only_notModified() throws Exception {
// there are no more change for any of the sub-ranges, but a split is happening on the first sub-range after
// the sub-range where we saw a 304 the first time.
// This effectively results in an endless-loop because we identify whether all sub-ranges are drained by
// capturing teh first subrange we see a 304 on and then loop through sub-ranges until we hit the same
// capturing the first subrange we see a 304 on and then loop through sub-ranges until we hit the same
// subrange without seeing anything but 304. When there is an even number of sub-ranges and a to-be-split
// sub-range is the last one - we never exit the loop after the split.
// This test is reproducing this edge case - and used both to validate the hotfix and to protect against
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ public void handlesNonCloneableMacSpiGracefully() {
MacPool.ReUsableMac secondMac = macPool.take();
assertThat(secondMac).isNotNull();

// expect 3 MACs to be created via the MacProvider - first is teh rootMac
// it isn't cloneable - so each of teh two calls to take (if no mac has been returned) would instantiate yet
// expect 3 MACs to be created via the MacProvider - first is the rootMac
// it isn't cloneable - so each of the two calls to take (if no mac has been returned) would instantiate yet
// another Mac bad for performance - but functionally correct and necessary because not every MacSpi is
// guaranteed to support cloning
// - see https://docs.oracle.com/javase/7/docs/technotes/guides/security/crypto/HowToImplAProvider.html#Step11
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1340,14 +1340,14 @@ public Mono<CosmosBatchResponse> executeCosmosBatch(
* @param <TContext> The context for the bulk processing.
* @param operations Flux of operation which will be executed by this container.
*
* @return A Flux of {@link CosmosBulkOperationResponse} which contains operation and it's response or exception.
* @return A Flux of {@link CosmosBulkOperationResponse} which contains operation and its response or exception.
* <p>
* To create a operation which can be executed here, use {@link com.azure.cosmos.models.CosmosBulkOperations}. For eg.
* for a upsert operation use {@link com.azure.cosmos.models.CosmosBulkOperations#getUpsertItemOperation(Object, PartitionKey)}
* </p>
* <p>
* We can get the corresponding operation using {@link CosmosBulkOperationResponse#getOperation()} and
* it's response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* its response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* successfully, the value returned by {@link com.azure.cosmos.models.CosmosBulkItemResponse#isSuccessStatusCode()} will be true. To get
* actual status use {@link com.azure.cosmos.models.CosmosBulkItemResponse#getStatusCode()}.
* </p>
Expand All @@ -1369,14 +1369,14 @@ public <TContext> Flux<CosmosBulkOperationResponse<TContext>> executeBulkOperati
* @param bulkOptions Options that apply for this Bulk request which specifies options regarding execution like
* concurrency, batching size, interval and context.
*
* @return A Flux of {@link CosmosBulkOperationResponse} which contains operation and it's response or exception.
* @return A Flux of {@link CosmosBulkOperationResponse} which contains operation and its response or exception.
* <p>
* To create a operation which can be executed here, use {@link com.azure.cosmos.models.CosmosBulkOperations}. For eg.
* for a upsert operation use {@link com.azure.cosmos.models.CosmosBulkOperations#getUpsertItemOperation(Object, PartitionKey)}
* </p>
* <p>
* We can get the corresponding operation using {@link CosmosBulkOperationResponse#getOperation()} and
* it's response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* its response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* successfully, the value returned by {@link com.azure.cosmos.models.CosmosBulkItemResponse#isSuccessStatusCode()} will be true. To get
* actual status use {@link com.azure.cosmos.models.CosmosBulkItemResponse#getStatusCode()}.
* </p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -986,14 +986,14 @@ public CosmosBatchResponse executeCosmosBatch(
* @param <TContext> The context for the bulk processing.
* @param operations list of operation which will be executed by this container.
*
* @return An Iterable of {@link CosmosBulkOperationResponse} which contains operation and it's response or exception.
* @return An Iterable of {@link CosmosBulkOperationResponse} which contains operation and its response or exception.
* <p>
* To create a operation which can be executed here, use {@link com.azure.cosmos.models.CosmosBulkOperations}. For eg.
* for a upsert operation use {@link com.azure.cosmos.models.CosmosBulkOperations#getUpsertItemOperation(Object, PartitionKey)}
* </p>
* <p>
* We can get the corresponding operation using {@link CosmosBulkOperationResponse#getOperation()} and
* it's response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* its response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* successfully, the value returned by {@link com.azure.cosmos.models.CosmosBulkItemResponse#isSuccessStatusCode()} will be true. To get
* actual status use {@link com.azure.cosmos.models.CosmosBulkItemResponse#getStatusCode()}.
* </p>
Expand All @@ -1015,14 +1015,14 @@ public <TContext> Iterable<CosmosBulkOperationResponse<TContext>> executeBulkOpe
* @param bulkOptions Options that apply for this Bulk request which specifies options regarding execution like
* concurrency, batching size, interval and context.
*
* @return An Iterable of {@link CosmosBulkOperationResponse} which contains operation and it's response or exception.
* @return An Iterable of {@link CosmosBulkOperationResponse} which contains operation and its response or exception.
* <p>
* To create a operation which can be executed here, use {@link com.azure.cosmos.models.CosmosBulkOperations}. For eg.
* for a upsert operation use {@link com.azure.cosmos.models.CosmosBulkOperations#getUpsertItemOperation(Object, PartitionKey)}
* </p>
* <p>
* We can get the corresponding operation using {@link CosmosBulkOperationResponse#getOperation()} and
* it's response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* its response using {@link CosmosBulkOperationResponse#getResponse()}. If the operation was executed
* successfully, the value returned by {@link com.azure.cosmos.models.CosmosBulkItemResponse#isSuccessStatusCode()} will be true. To get
* actual status use {@link com.azure.cosmos.models.CosmosBulkItemResponse#getStatusCode()}.
* </p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ private Mac createNewMac() {
return this.macProvider.get();
}

// Cloning teh rootMac is the fastest option
// Cloning the rootMac is the fastest option
// But while Mac implements Cloneable interface not every MacSpi is required to support cloning
// If it doesn't - bad for performance - but functionally correct and necessary
// - see https://docs.oracle.com/javase/7/docs/technotes/guides/security/crypto/HowToImplAProvider.html#Step11
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public PartitionKeyMismatchRetryPolicy(
/// <summary>
/// Should the caller retry the operation.
/// </summary>
/// <param name="exception">Exception that occured when the operation was tried</param>
/// <param name="exception">Exception that occurred when the operation was tried</param>
/// <param name="cancellationToken"></param>
/// <returns>True indicates caller should retry, False otherwise</returns>
public Mono<ShouldRetryResult> shouldRetry(Exception exception) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public PartitionKeyRangeGoneRetryPolicy(DiagnosticsClientContext diagnosticsClie
/// <summary>
/// Should the caller retry the operation.
/// </summary>
/// <param name="exception">Exception that occured when the operation was tried</param>
/// <param name="exception">Exception that occurred when the operation was tried</param>
/// <param name="cancellationToken"></param>
/// <returns>True indicates caller should retry, False otherwise</returns>
public Mono<ShouldRetryResult> shouldRetry(Exception exception) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ static HashMap<String, Double> parseDelimitedString(String delimitedString) {
String[] attributeKeyValue = StringUtils.split(attribute, "=");

if (attributeKeyValue.length != 2) {
throw new NullPointerException("recieved a malformed delimited STRING");
throw new NullPointerException("received a malformed delimited STRING");
}
Comment thread
ravening marked this conversation as resolved.

String attributeKey = attributeKeyValue[key];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1342,7 +1342,7 @@ static void safeSilentRelease(Object msg) {
try {
ReferenceCountUtil.release(msg);
} catch (Throwable t) {
// ReferenceCountUtil.safeRelease(msg); would always log teh warning below - which is unnecessary
// ReferenceCountUtil.safeRelease(msg); would always log the warning below - which is unnecessary
// in this class - we only needs this for a race condition rarely double-releasing
// logger.warn("Failed to release a message: {}", msg, t);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ public void putAll(final Map<? extends K, ? extends V> map) {
* uses {@link #put(Object, Object)}.
* <p>
* It is private to allow the constructor to still call it
* even when putAll is overriden.
* even when putAll is overridden.
*
* @param map the map to add
* @throws NullPointerException if the map is null
Expand Down
Loading
Loading