Fix trusted-endpoint validation for all authentication methods - #644
Merged
Conversation
Contributor
komal-rani522
force-pushed
the
fix/cwe-918-trusted-endpoint-validation
branch
from
August 13, 2026 05:03
127b8b4 to
ee3ef98
Compare
Copilot started reviewing on behalf of
Tanmaya Panda (tanmaya-panda1)
August 13, 2026 05:18
View session
Tanmaya Panda (tanmaya-panda1)
self-requested a review
August 13, 2026 05:19
Contributor
There was a problem hiding this comment.
Pull request overview
Enforces trusted-endpoint validation across authentication methods while delaying cloud metadata requests.
Changes:
- Applies validation to token and callback authentication.
- Lazily resolves cloud metadata.
- Adds trusted/untrusted endpoint tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
client_base.py |
Applies validation to all authenticated clients. |
kusto_trusted_endpoints.py |
Supports lazy login-endpoint resolution. |
test_endpoint_validation.py |
Tests validation and network-call prevention. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tanmaya Panda (tanmaya-panda1)
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforces trusted-endpoint validation for all authenticated clients and lazily resolves cloud metadata to prevent requests to untrusted hosts before validation.