[Containerapp] az containerapp logs show: Use replica log stream endpoint - #34048
Open
njucz (njuCZ) wants to merge 2 commits into
Open
[Containerapp] az containerapp logs show: Use replica log stream endpoint#34048njucz (njuCZ) wants to merge 2 commits into
njucz (njuCZ) wants to merge 2 commits into
Conversation
…oint Use the replica container logStreamEndpoint for console logs so express apps do not depend on eventStreamEndpoint. Continue using the container app eventStreamEndpoint for system logs and document the fix.
njucz (njuCZ)
requested review from
a team,
Greedygre (Greedygre),
Zunli Hu (Juliehzl) and
Hong Wang (howang-ms)
as code owners
September 9, 2026 08:42
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
ZelinWang (wangzelin007),
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 9, 2026 08:42
microsoft-github-policy-service
Bot
added
Auto-Assign
njucz (njuCZ)
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated log streaming path still retrieves an auth token but does not apply it to the outgoing request (Authorization header is a literal placeholder), which can break authentication and is dead code.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates az containerapp logs show to stream console logs using the replica container’s logStreamEndpoint (to avoid depending on the container app eventStreamEndpoint for console logs), while continuing to use the container app eventStreamEndpoint for system logs. Adds a release history note for the change.
Changes:
- For console logs, fetch the replica payload and use the selected container’s
logStreamEndpointdirectly. - For system logs, use the container app
properties.eventStreamEndpointdirectly. - Add a
HISTORY.rstentry documenting the behavior change.
File summaries
| File | Description |
|---|---|
| src/azure-cli/HISTORY.rst | Adds a release note for the az containerapp logs show endpoint fix. |
| src/azure-cli/azure/cli/command_modules/containerapp/custom.py | Switches console log streaming to use per-replica container logStreamEndpoint; keeps system logs on eventStreamEndpoint. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Chris Ross (Tratcher)
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ❌ Action needed
❌AzureCLI-FullTest
Use the replica container logStreamEndpoint for console logs so express apps do not depend on eventStreamEndpoint. Continue using the container app eventStreamEndpoint for system logs and document the fix.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.