[App Config] az appconfig enhanced-feature-flag: Add command group for enhanced feature flags - #34043
Open
Christine Wanjau (ChristineWanjau) wants to merge 1 commit into
Conversation
Add set/show/list/delete/enable/disable commands backed by the new data-plane FeatureFlagClient. Supports --telemetry-enabled and --fields (including variants and allocation); drops the --key property. Includes help, output formatting, params, a scenario test with recording, and a HISTORY entry.
Christine Wanjau (ChristineWanjau)
requested review from
a team
as code owners
September 8, 2026 10:26
microsoft-github-policy-service
Bot
requested review from
Avani Gupta (avanigupta),
Yu Chen (jsntcy),
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 8, 2026 10:26
microsoft-github-policy-service
Bot
added
App Configuration
Auto-Assign
Copilot started reviewing on behalf of
Christine Wanjau (ChristineWanjau)
September 8, 2026 10:26
View session
Christine Wanjau (ChristineWanjau)
changed the title
az appconfig enhanced-feature-flag: Add command group for enhanced feature flagsaz appconfig enhanced-feature-flag: Add command group for enhanced feature flags
Collaborator
|
App Config |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The enhanced feature flag serializer returns last_modified without normalizing datetime values, which can break downstream formatting/output handling.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new az appconfig enhanced-feature-flag command group to manage “enhanced feature flags” via the App Configuration data-plane FeatureFlagClient, wiring it into the App Config module’s command table, args, help, output formatting, and scenario tests.
Changes:
- Introduces
appconfig enhanced-feature-flagcommands (set/show/list/delete/enable/disable) backed byFeatureFlagClient. - Extends App Config command plumbing: new args/validators, help text, output formatting, and constants.
- Adds a new scenario test + recording; refactors shared data-plane client auth helper for
--auth-mode login.
File summaries
| File | Description |
|---|---|
| src/azure-cli/HISTORY.rst | Release note entry for the new command group |
| src/azure-cli/azure/cli/command_modules/appconfig/enhanced_feature.py | Implements enhanced feature flag CRUD/enable/disable and serialization |
| src/azure-cli/azure/cli/command_modules/appconfig/commands.py | Registers the new appconfig enhanced-feature-flag command group |
| src/azure-cli/azure/cli/command_modules/appconfig/_params.py | Adds parameters for enhanced feature flags (fields, tags, etc.) |
| src/azure-cli/azure/cli/command_modules/appconfig/_validators.py | Adds validator for enhanced feature --fields |
| src/azure-cli/azure/cli/command_modules/appconfig/_utils.py | Adds FeatureFlagClient factory + refactors login credential resolution |
| src/azure-cli/azure/cli/command_modules/appconfig/_help.py | Adds help + examples for the new commands |
| src/azure-cli/azure/cli/command_modules/appconfig/_format.py | Adds table output formatting for enhanced feature flags |
| src/azure-cli/azure/cli/command_modules/appconfig/_constants.py | Adds constants used in enhanced feature flag serialization |
| src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/test_appconfig_enhanced_feature_commands.py | Adds scenario coverage for enhanced feature flags |
| src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/recordings/test_azconfig_enhanced_feature.yaml | Adds recording for the new scenario test |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+214
to
+231
| def _serialize_feature_flag(feature_flag, fields=None): | ||
| result = { | ||
| FeatureFlagConstants.NAME: feature_flag.name, | ||
| FeatureFlagConstants.ENABLED: feature_flag.enabled, | ||
| FeatureFlagConstants.LABEL: feature_flag.label, | ||
| FeatureFlagConstants.DESCRIPTION: feature_flag.description, | ||
| FeatureFlagConstants.CONDITIONS: feature_flag.conditions.as_dict() if feature_flag.conditions is not None else None, | ||
| FeatureFlagConstants.VARIANTS: [variant.as_dict() for variant in feature_flag.variants] if feature_flag.variants is not None else None, | ||
| FeatureFlagConstants.ALLOCATION: feature_flag.allocation.as_dict() if feature_flag.allocation is not None else None, | ||
| FeatureFlagConstants.TELEMETRY: feature_flag.telemetry.as_dict() if feature_flag.telemetry is not None else None, | ||
| FeatureFlagConstants.TAGS: feature_flag.tags, | ||
| FeatureFlagConstants.LAST_MODIFIED: feature_flag.last_modified, | ||
| } | ||
|
|
||
| if fields: | ||
| return {field: result[field] for field in fields if field in result} | ||
|
|
||
| return result |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
Related command
az appconfig enhanced-feature-flagDescription
Adds a new
az appconfig enhanced-feature-flagcommand group backed by the new App Configuration data-planeFeatureFlagClient(fromazure-appconfiguration==1.10.0b1).Commands:
az appconfig enhanced-feature-flag set(required:--feature)az appconfig enhanced-feature-flag show(required:--feature)az appconfig enhanced-feature-flag listaz appconfig enhanced-feature-flag delete(required:--feature)az appconfig enhanced-feature-flag enable(required:--feature)az appconfig enhanced-feature-flag disable(required:--feature)Highlights:
.appconfig.featureflag/--keyproperty is intentionally not exposed (the dedicated/ff/endpoint manages the key server-side).--telemetry-enabled,--requirement-type,--description, and--tagsonset.--fieldssupportsname,enabled,label,description,conditions,variants,allocation,tags,last_modified.setperforms a get-then-update so unspecified fields (e.g.enabled,description,telemetry,tags) are preserved on update.Testing
test_azconfig_enhanced_featurescenario test (with recording) covering create/update/show/list/enable/disable/delete plus not-found error paths.This checklist is used to make sure that common guidelines for a pull request are followed.
HISTORY.rstentry.