chore: remove duplicate scriptless scenarios now that phase 2 is default#8979
Merged
Conversation
lilypan26
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
karenychen,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
titilambert,
xuexu6666 and
zachary-bailey
as code owners
July 17, 2026 21:16
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the E2E scenario suite to remove duplicated “_Scriptless” variants and consolidate coverage now that the newer scriptless bootstrap path is the default, while also aligning more scenarios to set equivalent values in both NBC and aksnodeconfigv1.Configuration.
Changes:
- Removed multiple duplicated
*_Scriptlessscenario tests and renamed remaining scenarios to their canonical names. - Added/expanded
AKSNodeConfigMutatorusage across scenarios to keep AKSNodeConfig fields in sync with NBC mutations (e.g., CA certs, network plugin, artifact streaming, kubelet config, GPU config). - Refactored and reorganized several artifact streaming and GPU scenarios to avoid redundant helper/test variants.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| e2e/scenario_test.go | Removes duplicated scriptless scenarios, renames tests, and adds/adjusts AKSNodeConfigMutator updates to align config between bootstrap paths. |
| e2e/scenario_localdns_hosts_test.go | Drops the separate scriptless LocalDNS test and folds AKSNodeConfig mutations into the main LocalDNS hosts plugin matrix. |
Comment on lines
44
to
47
| AKSNodeConfigMutator: func(_ *Cluster, config *aksnodeconfigv1.Configuration) { | ||
| config.LocalDnsProfile.EnableHostsPlugin = true | ||
| config.LocalDnsProfile.EnableLocalDns = true | ||
| }, |
awesomenix
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes duplicate scriptless scenarios to use phase 2.5 now that phase 2 is default
Which issue(s) this PR fixes:
Fixes #