fix: add credential provider config for custom cloud network isolated…#8962
Open
fseldow wants to merge 1 commit into
Open
fix: add credential provider config for custom cloud network isolated…#8962fseldow wants to merge 1 commit into
fseldow wants to merge 1 commit into
Conversation
… clusters When both AKS_CUSTOM_CLOUD_CONTAINER_REGISTRY_DNS_SUFFIX and BOOTSTRAP_PROFILE_CONTAINER_REGISTRY_SERVER are set (custom cloud + NI), the credential provider config was missing the --registry-mirror arg because the custom cloud branch took priority over the NI branch. This caused kubelet to fail authenticating against the bootstrap ACR, resulting in ImagePullBackOff for all system pods (azure-cni-node, kube-proxy, etc.) and nodes stuck in NotReady. Co-Authored-By: Claude <noreply@anthropic.com>
fseldow
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
karenychen,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
titilambert,
xuexu6666 and
zachary-bailey
as code owners
July 16, 2026 08:01
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Linux CSE credential provider config generation for the “custom cloud + network isolated” case by ensuring the kubelet ACR credential provider config includes the --registry-mirror argument when both AKS_CUSTOM_CLOUD_CONTAINER_REGISTRY_DNS_SUFFIX and BOOTSTRAP_PROFILE_CONTAINER_REGISTRY_SERVER are set.
Changes:
- Added a higher-priority branch in
writeCredentialProviderConfig()to generate a combined “custom cloud + network isolated” config including--registry-mirror=<mcr base>:<bootstrap ACR>. - Added a ShellSpec test case covering the combined environment-variable scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
parts/linux/cloud-init/artifacts/cse_config.sh |
Adds a dedicated config-generation branch for custom cloud + network isolated clusters so --registry-mirror is not omitted. |
spec/parts/linux/cloud-init/artifacts/cse_config_spec.sh |
Adds regression coverage asserting the combined config (including --registry-mirror) is written as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… clusters
When both AKS_CUSTOM_CLOUD_CONTAINER_REGISTRY_DNS_SUFFIX and BOOTSTRAP_PROFILE_CONTAINER_REGISTRY_SERVER are set (custom cloud + NI), the credential provider config was missing the --registry-mirror arg because the custom cloud branch took priority over the NI branch. This caused kubelet to fail authenticating against the bootstrap ACR, resulting in ImagePullBackOff for all system pods (azure-cni-node, kube-proxy, etc.) and nodes stuck in NotReady.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #