message-bus: rethrow handler errors, skip poison messages - #2
Open
ludamad wants to merge 1 commit into
Open
Conversation
The eachMessage wrapper swallowed handler exceptions, so kafkajs resolved the offset even when the handler's database write had failed — silently losing the event. Meanwhile a message that failed BSON deserialization threw outside the catch, crash-looping the partition on a permanently bad message. Both are inverted to the correct behavior: - handler errors are rethrown so the offset is not resolved and kafkajs redelivers (at-least-once; handlers are id-keyed upserts, safe to replay) - undeserializable messages are logged and skipped: retrying a poison pill can never succeed Identified in the AztecScan production-readiness audit (failed-message acknowledgement, immediate work order #1). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015mXnawSBPUySPtPwjLp5g1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eachMessage wrapper swallowed handler exceptions, so kafkajs resolved the offset even when the handler's database write had failed — silently losing the event. Meanwhile a message failing BSON deserialization threw outside the catch, crash-looping the partition on a permanently bad message. Both inverted to correct behavior: handler errors rethrow (offset unresolved → kafkajs redelivers; handlers are id-keyed upserts so replay is safe), undeserializable messages are logged and skipped.
From the production-readiness audit's immediate work order #1. Intended for upstream aztec-scan/chicmoz as well.
🤖 Generated with Claude Code
https://claude.ai/code/session_015mXnawSBPUySPtPwjLp5g1