chore(deps): drop unused packages, reclassify dev-only deps - #28
Open
alejoamiras wants to merge 1 commit into
Open
chore(deps): drop unused packages, reclassify dev-only deps#28alejoamiras wants to merge 1 commit into
alejoamiras wants to merge 1 commit into
Conversation
Remove @aztec/protocol-contracts (zero imports anywhere; still present transitively via aztec.js/pxe/wallets) and @commitlint/cli + @commitlint/config-conventional (no config file, no commit-msg hook, no CI usage - never invoked). Move every package used only by unpublished code (scripts/, benchmarks/, src/ts/test/) to devDependencies. Only @aztec/aztec.js remains a runtime dependency: it is the sole package imported by the published artifact bindings. No code changes; resolved packages drop from 743 to 668. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Benchmark Comparison
Contract: escrow
Contract: logic
Contract: multitoken
Contract: nft
Contract: token
Contract: vault
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Manifest-only dependency trim — zero code changes. Resolved packages in
yarn.lockdrop from 743 to 668.Removed (3 direct deps)
@aztec/protocol-contracts— zero imports anywhere in the repo (src, scripts, benchmarks, tests, workflows, generated artifacts). Remains available transitively viaaztec.js/pxe/wallets.@commitlint/cli+@commitlint/config-conventional— never invoked: no commitlint config file exists, nocommit-msghook (.husky/contains onlypre-commit), no CI reference.Reclassified runtime → dev
scripts/build-package.shpublishes onlydist/artifacts,target, README and LICENSE — the only package imported by shipped code is@aztec/aztec.js(via the generated artifact bindings). Everything else is exercised solely by unpublishedscripts/,benchmarks/, andsrc/ts/test/, so it moves todevDependencies:@aztec/accounts,@aztec/noir-contracts.js,@aztec/pxe,@aztec/stdlib,@aztec/wallet-sdk,@aztec/wallets,@aztec-foundation/aztec-benchmark,commander,dotenv.No install-behavior change: every consumer (CI included) runs a full
yarn install --frozen-lockfile; nothing installs production-only.Validation
yarn installregenerates the lockfile cleanly;yarn install --frozen-lockfilepasses (CI parity)require, dynamicimport()) across src, scripts, benchmarks, tests, workflows, and generated artifactsNotes for reviewers
undici,axios,vite,ws,esbuild,protobufjs) are ~96% transitives of the@aztec/*SDK andvitest→vite, not direct choices here.build-package.shstrips.dependenciesfrom the published package.json, so consumers never get@aztec/aztec.jsdeclared even though shippeddist/artifacts/*.jsimports it — works today only because consumers already install the Aztec SDK. Worth a follow-up.🤖 Generated with Claude Code