feat(greeter): auto-start external auth for howdy face recognition - #3128
Open
yuhaoxin wants to merge 1 commit into
Open
feat(greeter): auto-start external auth for howdy face recognition#3128yuhaoxin wants to merge 1 commit into
yuhaoxin wants to merge 1 commit into
Conversation
The greeter only auto-starts PAM external authentication for fprint and U2F. With howdy (pam_howdy.so) in the greetd PAM stack, the user must press Enter once before the camera activates. Detect pam_howdy in the PAM stack like pam_fprintd/pam_u2f, include it in greeterExternalAuthAvailable/greeterPamHasExternalAuth, and show a matching status message. Presence in the PAM stack implies intent, so no settings toggle is added.
Collaborator
|
I'm ok to merge this to the stable branch, but it needs to go to the dank-greeter repo since 1.6+ will be using that one https://github.com/AvengeMedia/dank-greeter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The greeter auto-starts PAM external authentication (via
maybeAutoStartExternalAuth) only for fingerprint (pam_fprintd) and security keys (pam_u2f). When howdy face recognition (pam_howdy.so) is in the greetd PAM stack, the camera stays off until the user presses Enter once — defeating the purpose of face login.Change
Treat
pam_howdylike the other external auth modules:greeterPamHasHowdydetectspam_howdyin the effective PAM stack (reusinggreeterPamStackHasModule)greeterExternalAuthAvailable/greeterPamHasExternalAuth, somaybeAutoStartExternalAuth()fires and the camera activates as soon as the password view is shownNo settings toggle is added: presence of
pam_howdy.soin the PAM stack is an explicit admin choice, same as the module ordering. Unlike fprint, howdy has no D-Bus probe equivalent, so PAM-stack detection is authoritative (howdy exits quickly withPAM_AUTHINFO_UNAVAILwhen disabled via its own config).Testing
pam_howdy.so),auth sufficient pam_howdy.soin/etc/pam.d/greetdqmllintclean