fix(launcher): DankLauncherV2 was missing id and genericName search - #3122
Open
z1-0 wants to merge 1 commit into
Open
fix(launcher): DankLauncherV2 was missing id and genericName search#3122z1-0 wants to merge 1 commit into
z1-0 wants to merge 1 commit into
Conversation
z1-0
marked this pull request as draft
August 20, 2026 10:04
z1-0
force-pushed
the
feat/search-by-exec
branch
2 times, most recently
from
August 20, 2026 10:57
3d31382 to
3cb868c
Compare
…rV2 scorer Scorer was dropping apps that only matched on id or genericName, even though AppSearchService.searchApplications already matches both. Add id (350) and genericName (prefix 800, contains 400) tiers so the V2 launcher ranks those apps the same way.
z1-0
force-pushed
the
feat/search-by-exec
branch
from
August 22, 2026 21:12
706364a to
48825b0
Compare
z1-0
changed the title
z1-0
changed the title
z1-0
marked this pull request as ready for review
August 22, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Almost every mainstream launcher matches by id, and most also support generic name. DankLauncherV2 didn't have it.
AppSearchService already matches apps by their desktop id and generic name, but DankLauncherV2's Scorer never picked those up. So when an app only matched on id or genericName, launcher just skipped it.
What changed
.desktopsuffix.Tested
I tested it on my own machine. Typing an app's id (org.kde.dolphin) or its generic name (Web Browser) now finds it in the V2 launcher.