fix(nix): declare notification bus readiness - #2994
Draft
domenkozar wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The NixOS and Home Manager modules declared DMS as started before its QuickShell process acquired
org.freedesktop.Notifications. Consumers ordered afterdms.servicecould therefore initialize too early and permanently fall back to non-system notifications.Configure both module variants as
Type=dbuswithBusName=org.freedesktop.Notifications. Update the service-start test double to acquire that name and assert the readiness contract in both module tests.This lets dependent user services reliably use
After=dms.service.Type of change
Related issues
None.
Screenshots / video
Not applicable; this changes service startup ordering.
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warningsValidation:
nix flake check --no-build --show-tracenix build .#nixosTests.x86_64-linux.nixos-service-start-module