Skip to content

Fail closed on PHPUnit discovery errors#1940

Merged
chubes4 merged 4 commits into
mainfrom
fix/1916-malformed-bootstrap-diagnostics
Jul 21, 2026
Merged

Fail closed on PHPUnit discovery errors#1940
chubes4 merged 4 commits into
mainfrom
fix/1916-malformed-bootstrap-diagnostics

Conversation

@chubes4

@chubes4 chubes4 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • allow empty PHPUnit success only for a valid, non-empty changed-test scope that matches no tests
  • fail on missing test roots, missing or malformed XML configuration, and generic zero-test discovery
  • preserve implicit phpunit.xml.dist to phpunit.xml fallback while keeping explicit configuration fail-closed before bootstrap execution

Verification

  • npm run build
  • npx tsx tests/phpunit-project-autoload.test.ts
  • npm run test:phpunit-runtime-failure-diagnostics
  • npm run test:playground-phpunit-bootstrap-failure-integration
  • git diff --check

Follow-up to #1933. Addresses the empty-suite regression documented in #1916.

@chubes4
chubes4 merged commit a9edf31 into main Jul 21, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant