You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Normalize bounded same-origin external SVG images through Blob-backed decoding before screenshots.
What changed
Fetch eligible same-origin SVG bytes with timeout and size bounds, render them through temporary Blob URLs, decode them, and revoke URLs after capture.
Extend browser coverage to prove an already-complete same-origin SVG takes the Blob-backed decode path.
How to test
Run npm install; expect Dependencies install successfully..
Run npm run build; expect TypeScript packages build successfully..
Run npm exec -- tsx tests/browser-visual-compare-capture-reliability.test.ts; expect The capture reliability suite passes, including same-origin external SVG Blob normalization..
Compatibility
No command or output schema changes. Raster, responsive, cross-origin, oversized, and failed SVG requests retain their existing paths.
Evidence
Base advanced after verification: verified main at 7b1e774; publication observed c4cb30a. Candidate ancestry was validated against the verified snapshot.
Downstream acceptance failed. The exact PR build completed the canonical solved 15-saas fixture matrix with 100% native conversion, zero invalid blocks, complete font embedding (3/3 expected SVGs), and unchanged outer image geometry, but the result remained exactly 8,300 / 9,958,080 mismatched pixels (0.08%). The same eight regions remain confined to text inside two SVG mockups.
This disproves both candidate hypotheses for this fixture: calling decode() for complete images and rehydrating same-origin external SVGs through Blob URLs do not change the output. This PR should not be treated as satisfying issue #1902 acceptance criterion 4. The next investigation should capture bounded source/generated SVG payload hashes and effective text/font attributes to locate deterministic serialization differences before changing capture behavior again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize bounded same-origin external SVG images through Blob-backed decoding before screenshots.
What changed
How to test
npm install; expect Dependencies install successfully..npm run build; expect TypeScript packages build successfully..npm exec -- tsx tests/browser-visual-compare-capture-reliability.test.ts; expect The capture reliability suite passes, including same-origin external SVG Blob normalization..Compatibility
No command or output schema changes. Raster, responsive, cross-origin, oversized, and failed SVG requests retain their existing paths.
Evidence
AI assistance
Source relationships