Agentic UI: Remove unused starred flag from AI chat sessions#4229
Open
bcotrim wants to merge 1 commit into
Open
Agentic UI: Remove unused starred flag from AI chat sessions#4229bcotrim wants to merge 1 commit into
bcotrim wants to merge 1 commit into
Conversation
Collaborator
📊 Performance Test ResultsComparing 48d8a9a vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude traced every reference to the
starredsession flag across the codebase, removed the dead plumbing, updated the tests, and ran lint/typecheck/tests. Changes were reviewed and the archive flow was manually testedProposed Changes
The star/unstar UI for chat conversations was removed in #4191, which left the
starredsession-metadata flag as dead plumbing: nothing could set it and nothing displayed it. This PR retires the flag end-to-end — from the shared-config schema, session types and hydration, the IPC handler, the hosted/local PATCH endpoints, and the UI data layer.shared.jsonfiles with leftoverstarredentries still parse fine. Those stale flags are now purged on the next session-metadata write.Testing Instructions
starred— the only remaining reference is the legacy-flag purge inpruneSharedSessionMetadata(and its test).~/.studio/shared.json: the archived chat has{ "archived": true }, and any pre-existing"starred"entries are removed after that write.Pre-merge Checklist
🤖 Generated with Claude Code