Decrease windows build time caused by data-liberation-agent#4185
Merged
Conversation
nightnei
changed the title
Collaborator
📊 Performance Test ResultsComparing 2583451 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
sejas
approved these changes
Jul 13, 2026
sejas
left a comment
sejas
left a comment
Member
There was a problem hiding this comment.
Changes look good! I was able to run Studio Code and the liberate skill without any issues 👍
|
|
||
| async function connectClient(): Promise< Client > { | ||
| if ( ! existsSync( path.join( engineDir, 'dist', 'mcp-server.js' ) ) ) { | ||
| if ( ! existsSync( path.join( engineDir, 'dist', 'mcp-server.bundle.mjs' ) ) ) { |
Member
There was a problem hiding this comment.
Claude suggested this filename renaming too 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI assisted with investigation and writing code
Proposed Changes
As mentioned in the issue STU-2027 - build time for Windows x64 increases by 8 minutes. Interesting results of the investigations are in comments under the Linear issue.
The sultion - we already have mcp-server.bundle.mjs so we can reuse it, additionally clone skills and otehr necessary files and remove direct dependency.
As a result:
Example w/o data-liberations (it was taken from this test PR #4176):
Example after changes in this PR(I did 2 tests):
Testing Instructions
Visual review should suffice, but you can test with:
npm run cli:build && node apps/cli/dist/cli/main.mjs code/liberate https://neicss.wixsite.com/sunflower-valley-exp