Skip to content

Remove per-tooltip delay overrides so all tooltips share one delay#4129

Merged
bcotrim merged 2 commits into
trunkfrom
share-tooltip-delay
Jul 13, 2026
Merged

Remove per-tooltip delay overrides so all tooltips share one delay#4129
bcotrim merged 2 commits into
trunkfrom
share-tooltip-delay

Conversation

@bcotrim

@bcotrim bcotrim commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

Commit cherry-picked from #3998 (authored by @shaunandrews with AI assistance); Claude Code handled the cherry-pick onto trunk and ran lint/typecheck/tests.

Proposed Changes

  • The composer toolbar (add-attachment, model pill, stop, send) and the site dropdown trigger each wrapped their tooltip in a local Tooltip.Provider delay={ 0 }, so those tooltips popped instantly while the rest of the app used the default hover delay.
  • Drops the local overrides so every tooltip inherits the app-wide provider (AppProviders) and its default delay/hover group — one consistent tooltip feel across the app.
  • The composer test harness keeps a zero delay locally so its assertions stay deterministic.

Testing Instructions

  • Open the agentic UI and hover the composer buttons (attachment, model pill, send/stop) and the site dropdown trigger.
  • Tooltips should appear after the same default hover delay as other tooltips in the app (no longer instantly), and still display correctly.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

🤖 Generated with Claude Code

Drops the local Tooltip.Provider delay={ 0 } wrappers on the chat footer, composer toolbar, and site dropdown so every tooltip inherits the app-wide provider's default hover delay and shares its hover group. Moves the zero delay into the composer test harness to keep those assertions deterministic.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bcotrim
bcotrim marked this pull request as ready for review July 9, 2026 19:14
@bcotrim
bcotrim requested review from a team and katinthehatsite July 9, 2026 19:14
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 72ba0dd vs trunk

app-size

Metric trunk 72ba0dd Diff Change
App Size (Mac) 1419.26 MB 1419.26 MB 0.00 MB ⚪ 0.0%

site-editor

Metric trunk 72ba0dd Diff Change
load 1083 ms 1079 ms 4 ms ⚪ 0.0%

site-startup

Metric trunk 72ba0dd Diff Change
siteCreation 7007 ms 6998 ms 9 ms ⚪ 0.0%
siteStartup 2358 ms 2354 ms 4 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@gavande1 gavande1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@bcotrim
bcotrim merged commit b08043a into trunk Jul 13, 2026
11 checks passed
@bcotrim
bcotrim deleted the share-tooltip-delay branch July 13, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants