Workflow branch executor: return truthful async runner dispatch result#420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
trigger_async_runner()returned the full worker count even when every loopback request failed, fabricating dispatch success; callers could not fall back.Fix
Count only accepted loopback responses from
Requests::request_multiple(); return 0 when all fail. New smoke test covering all-failed and mixed cases.Context
Discovered on a WP Cloud runtime with no reachable loopback (connection refused on 127.0.0.1:80/443) and DISABLE_WP_CRON=true, where Action Scheduler jobs stayed pending forever while the executor reported success. Downstream consumer fix lands separately in the wp-build repo (GHE chubes4/wp-build#1149).
AI assistance