fix(comms): hide blasts sent before the sender closed their inbox - #1047
Merged
Merged
Conversation
GET /comms/blasts and chat creation still listed blasts sent before the artist closed their inbox, so recipients saw a pending blast they could not reply to. Apply the same cutoff hasNewBlastFromUser uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd chat_allowed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comms/chat.gogetNewBlasts) now skip blasts older than the sender's last inbox-settings change, matchinghasNewBlastFromUserandchat_allowedfrom fix(comms): closing the inbox stops new DMs from earlier blast recipients #1036. Before this, a follower who hadn't opened an old blast still saw it after the artist closed their inbox, and tapping it failed with "Not permitted to send messages to this user".Comment cleanup: shorter comments in weeklyrotation/period.go, v1_challenges_info.go (+ one test name), chat_allowed (ddl and sql/01_schema.sql), and chat_inbox_closed_test.go.
Tests:
go test ./api/comms/,go test ./api/ -run 'Blast|Chat|Comms|TestWeeklyPoolWindowStartAt|TestV1ChallengesInfo',go test ./weeklyrotation/, all passing. NewTestGetNewBlastsAfterSenderClosesInboxand the new pending-blast assertions inTestChatBlastThenCloseInboxfail without the fix.🤖 Generated with Claude Code