Skip to content

refactor: rename situations module to situations-and-notices#752

Merged
strandlie merged 1 commit into
mainfrom
strandlie/notifications-rename
Jul 8, 2026
Merged

refactor: rename situations module to situations-and-notices#752
strandlie merged 1 commit into
mainfrom
strandlie/notifications-rename

Conversation

@strandlie

@strandlie strandlie commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Why

modules/situations isn't situation-specific. It handles both situations and
notices — the two kinds of user-facing journey notifications — via
SituationOrNoticeIcon, getMsgTypeForMostCriticalSituationOrNotice,
filterNotices, etc., and is consumed across assistant and departures wherever
these are shown. The name reflected only one of its two data types.

Per the review discussion, the module is named situations-and-notices (rather than
notifications, which collides with mobile push-notification terminology).

What

Pure rename, zero behavioral change:

  • git mv src/modules/situationssrc/modules/situations-and-notices (internal
    file/component names kept — they accurately describe specific renderers/helpers).
  • Repointed the 10 importers from @atb/modules/situations to @atb/modules/situations-and-notices.

Extracted from the travel-card PR (#751) so the rename can be reviewed in isolation.

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
planner-web Ready Ready Preview, Comment Jul 8, 2026 8:35am

Request Review

@gorandalum gorandalum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, and I am for a renaming as the module doesn't just handle situations. But I am a little unsure about using the term "notifications" as it is already used for mobile notifications. What about just naming the module "situations-and-notices"?

@strandlie

Copy link
Copy Markdown
Contributor Author

The changes look good, and I am for a renaming as the module doesn't just handle situations. But I am a little unsure about using the term "notifications" as it is already used for mobile notifications. What about just naming the module "situations-and-notices"?

Yes, I think the same. The reason I landed on notification was because we use that term in the app when a leg has notices or situations. But 100% open to changing it. Thoughts @rosvik ?

@rosvik

rosvik commented Jul 8, 2026

Copy link
Copy Markdown
Member

I agree with @gorandalum here! I think push notifications when I read that word, but "situations-and-notices" works 👍

@strandlie strandlie force-pushed the strandlie/notifications-rename branch from 60ea633 to ba63c64 Compare July 8, 2026 08:19
@strandlie strandlie changed the title refactor: rename situations module to notifications refactor: rename situations module to situations-and-notices Jul 8, 2026
@strandlie strandlie force-pushed the strandlie/notifications-rename branch from ba63c64 to 34ea6db Compare July 8, 2026 08:33
@strandlie strandlie merged commit 2772a7e into main Jul 8, 2026
5 checks passed
@strandlie strandlie deleted the strandlie/notifications-rename branch July 8, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants