fix: preserve disabled session knowledge bases - #9456
Open
lxfight wants to merge 1 commit into
Open
Conversation
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session editor previously treated an empty knowledge base selection as missing configuration and deleted
kb_config. The backend then inherited the global configuration, so a session that intentionally disabled all knowledge bases would search every globally enabled knowledge base.Modifications / 改动点
kb_idslist when a session should use no knowledge bases.Screenshots or Test Results / 运行截图或测试结果
Verification steps:
cd dashboard pnpm buildResults:
Checklist / 检查清单
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。/ 我的更改没有引入恶意代码。
Summary by Sourcery
Clarify session-level knowledge base behavior by adding explicit global inheritance controls and preserving empty knowledge base selections so sessions can intentionally disable all knowledge bases.
New Features:
Bug Fixes:
Enhancements: