Make laser parameters configurable; utility function for tunable laser - #970
Draft
oczoske wants to merge 3 commits into
Draft
Make laser parameters configurable; utility function for tunable laser#970oczoske wants to merge 3 commits into
oczoske wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 75.89% 75.92% +0.03%
==========================================
Files 70 70
Lines 9030 9050 +20
==========================================
+ Hits 6853 6871 +18
- Misses 2177 2179 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
teutoburg
approved these changes
Aug 12, 2026
teutoburg
left a comment
Contributor
There was a problem hiding this comment.
See individual comments, but overall fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The laser parameters (wavelength, power) are now taken from
wcu.meta, i.e. from a config file or from kwargs.All parameters can be changed by doing, e.g.
set_lampis necessary to recompute the lamp emission.The wavelengths of the tunable laser should be more easily accessible to the user, therefore a utility method is offered (this recomputes the emission automatically):
A validation method for the wavelengths has been implemented but is not yet used as we do not have reliable information on the actually available wavelength range.