Repository navigation
fix: wrap small integers before casting them to bool - #3065
Open
SwastikTripathi wants to merge 1 commit into
Open
SwastikTripathi wants to merge 1 commit into
SwastikTripathi wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3057.
Changes proposed in this pull request:
An explicit cast of a small integer (
i8,u8,i16,u16) tobool(<bool>x,x as bool,bool(x)) now clears the bits above the small type before testing the value. Before,convertExpressiononly wrapped small integers when converting to a larger type, andbool(size 1) never qualified, so a value that overflowed to 0 in its own type still tested astrue:The conditional form (
c ? true : false) already went throughmakeIsTrueish, which wraps, so only the explicit cast was affected.Added cases to
tests/compiler/bool.tsforu8,i8,u16andi16values that wrap to 0 (and some that don't). With the old compiler the module aborts on the first new assertion; with the fix it runs. Regenerated theboolandcastfixtures;cast.debug.watchanges because it contains such casts (ani32.and/sign-extension now precedes thei32.ne).npm run test:compilerpasses.