Skip to content

net: phy: an8801: add support for more condition and issue fixes#4

Open
kevin-kw-huang wants to merge 1 commit into
AspeedTech-BMC:aspeed-master-v6.18from
kevin-kw-huang:aspeed-master-v6.18
Open

net: phy: an8801: add support for more condition and issue fixes#4
kevin-kw-huang wants to merge 1 commit into
AspeedTech-BMC:aspeed-master-v6.18from
kevin-kw-huang:aspeed-master-v6.18

Conversation

@kevin-kw-huang

Copy link
Copy Markdown

Support configurations for:

  1. MDI adding 5ohm surge protection
  2. AN8801R output clock
  3. Debugfs

@aspeedJacky

Copy link
Copy Markdown

@kevin-kw-huang

Got some error with this patch, please confirm it.

/work/linux/drivers/net/phy/an8801.c:769:6: error: no previous prototype for ‘update_r50_value’ [-Werror=missing-prototypes]
  769 | void update_r50_value(struct phy_device *phydev,
      |      ^~~~~~~~~~~~~~~~
/work/linux/drivers/net/phy/an8801.c:780:5: error: no previous prototype for ‘calculate_position’ [-Werror=missing-prototypes]
  780 | int calculate_position(int pos, int shift, int table_size)
      |     ^~~~~~~~~~~~~~~~~~
/work/linux/drivers/net/phy/an8801.c:788:5: error: no previous prototype for ‘process_r50’ [-Werror=missing-prototypes]
  788 | int process_r50(struct phy_device *phydev, int reg,
      |     ^~~~~~~~~~~
/work/linux/drivers/net/phy/an8801.c:804:5: error: no previous prototype for ‘an8801r_surge_protect_cfg’ [-Werror=missing-prototypes]
  804 | int an8801r_surge_protect_cfg(struct phy_device *phydev)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~
/work/linux/drivers/net/phy/an8801.c:1098:5: error: no previous prototype for ‘an8801r_info_show’ [-Werror=missing-prototypes]
 1098 | int an8801r_info_show(struct seq_file *seq, void *v)
      |     ^~~~~~~~~~~~~~~~~
/work/linux/drivers/net/phy/an8801.c:1154:5: error: no previous prototype for ‘an8801r_debugfs_init’ [-Werror=missing-prototypes]
 1154 | int an8801r_debugfs_init(struct phy_device *phydev)
      |     ^~~~~~~~~~~~~~~~~~~~

@aspeedJacky

Copy link
Copy Markdown

@kevin-kw-huang

It is done with two patches, but they are one thing on "net: phy: an8801: add support for more", so please merge the fix patch with the first patch to single patch for us. Thanks.

Support configurations for:
1. MDI adding 5ohm surge protection
2. AN8801R output clock
3. Debugfs

Signed-off-by: Kevin-KW.Huang <kevin-kw.huang@airoha.com>
@kevin-kw-huang

Copy link
Copy Markdown
Author

Merged the fix patch to the first patch.

@aspeedJacky

Copy link
Copy Markdown

@kevin-kw-huang Thanks.
This patch will be merged and released in next SDK version.

@kevin-kw-huang

Copy link
Copy Markdown
Author

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants