power: supply: macsmc: make force-discharge to the charge limit configurable - #521
Open
BoiledElectricity wants to merge 4062 commits into
Open
power: supply: macsmc: make force-discharge to the charge limit configurable#521BoiledElectricity wants to merge 4062 commits into
BoiledElectricity wants to merge 4062 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowering the charge limit always sets
CHLS_FORCE_DISCHARGE, so the battery actively drains down to the limit even on AC. Add aforce_dischargemodule param (default on = no behaviour change) to make that opt-out, so the limit can just cap charging instead.Resolves the in-code TODO. Tested on M1 MacBook Pro (j293).