Repository navigation
native: diag() reads jvector's provider through the engine - #156
Merged
Merged
Conversation
ArcadeNative.diag called VectorizationProvider.getInstance() directly. jvector picks its provider once per process, so a diag() before the first database took the choice away from the engine's VectorApiSupport.configureJVectorProvider() (scalar in a native image): Panama (the uncompiled Vector API) on macOS and Windows, which failed the nightly parity legs there on test_the_default_provider_follows_the_shipped_library. Reproduced on Linux x86-64 with the dev wheel: diag() first keeps jvector's own provider after a database and vector index are created; the database first gets DefaultVectorizationProvider. VectorApiSupport.jvectorProvider() (public since engine 26.10.2) runs the engine's choice first. Closes #155 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArcadeNative.diagread jvector's provider withVectorizationProvider.getInstance(). jvector picks its provider once per process, so adiag()before the first database took the choice away from the engine'sVectorApiSupport.configureJVectorProvider(), which forces the scalar provider in a native image. On macOS and Windows jvector's own choice is Panama (the uncompiled Vector API), which failed the nightly parity legs there (#155).diag()now reads the provider throughVectorApiSupport.jvectorProvider(), public since engine 26.10.2, which runs the engine's choice first.The existing
test_the_default_provider_follows_the_shipped_libraryalready callsdiag()first in a fresh process, so it is the regression test; its helper's docstring now says so.Verification: pull requests build only linux-x86_64, so before merging I dispatch this workflow on the branch (all four platforms, Python 3.12 and 3.14) and merge only when the macos-arm64 and windows-x64 parity legs pass.
Closes #155
🤖 Generated with Claude Code