Reuse a consistent toolkit data snapshot#1078
Open
jottakka wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jottakka
marked this pull request as draft
July 17, 2026 03:44
Contributor
Author
|
bugbot run |
|
Current version of PR was reviewed by /review-bugbot on Jul 17, 00:53 GMT-3. It flagged 0 findings. Bugbot on commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm exec tsc --noEmit --project toolkit-docs-generator/tsconfig.jsonpnpm exec vitest run --root toolkit-docs-generatorNote
Medium Risk
Changes affect incremental generation and change detection against live APIs; a false positive on the empty-snapshot guard could block legitimate runs, while the cache fixes real consistency bugs during multi-phase CLI flows.
Overview
Generation runs now wrap the toolkit data source with
createCachedToolkitDataSource, sofetchAllToolkitsDatais called once per run and change detection, progress, and merging share the same in-memory map instead of independent API reads that can diverge mid-run.Incremental and dry-run flows add
assertSafeCurrentToolkitSnapshot, which fails when the current snapshot is empty but prior generated output still has toolkits—blocking mistaken “remove everything” cleanup from a transient empty API response.generate --skip-unchangedandcheck-changesinvoke this guard before diffing.Vitest coverage was added for the cache wrapper (single fetch, shared promise) and the snapshot safety check.
Reviewed by Cursor Bugbot for commit 7e705cb. Bugbot is set up for automated code reviews on this repo. Configure here.