Repository navigation
Fix clipboard sync negotiation after protocol v3 upgrade - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Desktop peers upgraded to clipboard replication v3 authenticate successfully, then disconnect because the welcome check only accepts v1 and v2. Validate the selected version against the same protocol constant advertised in the hello, while retaining the legacy control path for older negotiated versions and rejecting missing, unselected, zero, and future versions.
Add a real paired QUIC handshake regression through the desktop connection manager. It checks that the current version reaches the connected state, registers the replica transport, and transfers distinct text records in both directions without closing the control connection.
The integration packaging job also failed on Xcode 27 because the share extension inherited a macOS 10.13 target. Set that extension's minimum to macOS 12.0 in both the XcodeGen source and checked-in project so the CI package can be produced.
Validation
cargo fmt --all -- --checkcargo check --workspace --all-targetscargo clippy -p arcrelay-desktop --all-targets -- -D warningsPublic boundary