fix(examples): remove mavenLocal now that dependencies are released - #42
Merged
Conversation
hexagonal-spring-rules 0.5.0 and the architecture-validator plugin 0.7.2 are both now published (Maven Central and the Gradle Plugin Portal respectively), so the six new example projects and jacoco-marker no longer need mavenLocal() as a fallback repository. Pin to the real released versions and remove the local-only repository entries so these examples build for anyone from a clean checkout, not just this machine's local Maven cache. Verified every example still produces its documented failure set with mavenLocal() fully absent from the repositories list (forcing resolution purely from Maven Central / Gradle Plugin Portal). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mavenLocal()from the six newhexagonal-spring-*example projects (bothbuild.gradleandsettings.gradle'spluginManagement) and fromexamples/sedr-library/jacoco-marker/build.gradle.architecture-validator-hexagonal-spring-rules = 0.5.0andarchitecture-validator = 0.7.2, replacing the local-only1.0.0-PRERELEASE/0.0.1versions that only ever existed in one machine's~/.m2cache.jacoco-marker's now-stale "publish sedr-library locally first" instructions —sedr-libraryhas been on Maven Central since 0.4.5.These were flagged during review of #41: examples in this repo shouldn't depend on
mavenLocal(), since that only works on the machine that happened to publish locally and silently fails for anyone else cloning the repo. That dependency existed only because the underlying artifacts weren't released yet; now that they are (0.5.0 and 0.7.2), it can go away.