maintenance: Fix dependency compatibility and update package versions - #80
Merged
Conversation
Updated NPM packages: - @semantic-release/changelog: ^6.0.3 -> ^7.0.0 - @semantic-release/git: ^10.0.1 -> ^11.0.1 Warnings: - npm audit fix may introduce breaking changes; review updates before deploying. - npm audit fix returned a non-zero exit code; vulnerabilities may remain unresolved.
Updated libs.versions.toml: - gherkin-to-asciidoc: 1.1.0 -> 1.2.0 - cucumber-java: 7.22.1 -> 7.34.6
Updated libs.versions.toml: - cucumber-java: 7.22.1 -> 7.34.6
Updated NPM packages: - @semantic-release/changelog: ^6.0.3 -> ^7.0.0 - @semantic-release/git: ^10.0.1 -> ^11.0.1 Warnings: - npm audit fix may introduce breaking changes; review updates before deploying. - npm audit fix returned a non-zero exit code; vulnerabilities may remain unresolved.
Updated NPM packages: - @semantic-release/changelog: ^6.0.3 -> ^7.0.0 - @semantic-release/git: ^10.0.1 -> ^11.0.1 Warnings: - npm audit fix may introduce breaking changes; review updates before deploying. - npm audit fix returned a non-zero exit code; vulnerabilities may remain unresolved.
Updated libs.versions.toml: - cucumber-expressions: 18.0.1 -> 20.0.0 - gherkin: 41.0.0 -> 42.0.0
….match() The gherkin/cucumber-expressions dependency bump (18.0.1->20.0.0, 41.0.0->42.0.0) changed Expression.match() to return Optional<List<Argument<?>>> instead of a nullable list. The null-check in ScenarioClassifier was always true for a present-but- empty Optional, so every step was misclassified as IMPLEMENTED. Same issue silently neutered the isNotNull() assertions in GlueCodeScannerTest. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Arc-E-Tect
added
bug
Owner
Author
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses the following:
gherkin-to-asciidocwhere changes inExpression.match()method's return type fromcucumber-expressionscaused steps to be misclassified as IMPLEMENTED.libs.versions.tomlupdated (e.g., cucumber-expressions, gherkin, and cucumber-java).@semantic-release/changelog,@semantic-release/git).