Repository navigation
fix: reuse verified context and bound incomplete review work - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse verified context and avoid spending the remaining execution budget after an irrecoverable review prerequisite fails.
Keep the global 20-minute and 100-provider-request limits unchanged. Bound the context socket separately to 100 requests, including invalid requests; probes and contents for one snapshot/path share a lookup slot. Preserve primary execution failure alongside allowlisted completion flags and lookup counters. Modified old source remains hash-verified and mounted; complete patches/current or deleted source are supplied without retransmitting full modified old text.
Evidence
npm run checkpasses251 tests, strict types, lint and build. Clean-checkout, real workerd/D1, browser, catalog, Actionlint and audit pass. Both full GitHub CI runs pass, including20 real pinned-Codex Docker scenarios with scripted Responses, isolation and security scanning. No local Docker daemon was started.gpt-6.1-sol/xhigh, four commits,93 files/8412 changed lines,89 modified text files, four distinct640x360 PNGs, unchanged transitive JSON fixtures. All6 groups plus synthesis complete, host context complete, zero unfinished reasons. Both introduced authorization and stale-response defects are published at valid changed lines in one App-owned native COMMENT, bound to the exact head. Review step9m08s, including preparation, without extending execution limits. The test used an operator-signed isolated delivery based on fresh real GitHub comment metadata; GitHub dispatch/OIDC, runner, ChatGPT inference and publication were genuine. No production webhook was rerouted.Merge Danger
Door: two-way. No migration, dependency upgrade, credential, quota, approval or merge-policy change. Rollback still requires coordinated immutable caller/Worker trust pins.
Blast Radius: runner. Existing path/object/hash/byte/API limits and essential-evidence failure remain enforced. Synthetic and controlled live fixtures do not guarantee arbitrary heterogeneous xhigh PRs finish within20minutes. Production/KMU remain unchanged pending acceptance and protected merge.