Repository navigation
fix: pin selectolax so wiki images render again - #1170
Merged
Merged
Conversation
selectolax 1.0.1 (a dependency of mkdocs-glightbox 0.5.2) makes the glightbox plugin drop every image from the built pages. The deploy at 03:37Z on 2026-10-19 published the wiki with empty <p></p> where every content image should be. Pinning selectolax<1.0.1 restores them (3158 images in the local build, 410 with 1.0.1). check_links.py now also fails when the built site has fewer than half as many images as the Markdown, so a plugin regression like this one fails the PR checks instead of reaching the live site. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live wiki lost every content image in today's deploy (03:37Z). Each image is now an empty
<p></p>.Cause:
selectolax1.0.1, a dependency ofmkdocs-glightbox0.5.2, makes the glightbox plugin drop images from the built HTML. CI installs unpinned packages, so the deploy picked it up. I reproduced it locally: with 1.0.1,products/temp1/troubleshooting/temp1-code/has 0 images, and with 1.0.0 it has all 5.Fix:
requirements.txt:selectolax<1.0.1, with a comment explaining why.check_links.py: now fails when the built site has fewer than half as many images as the Markdown. The broken build has 410 images built versus about 1,867 in the Markdown, so it fails. The pinned build has 3,158, so it passes.Tested locally:
pip install -r requirements.txtresolves selectolax 1.0.0,mkdocs buildsucceeds, andcheck_linksreports 681 pages, 3,158 images and 0 errors.🤖 Generated with Claude Code