Repository navigation
Fix OTA manifest lambda for ESPHome dev - #117
Conversation
Release 26.8.19.1: merge beta into main
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe default ESPHome firmware version changed to ChangesESPHome Firmware Updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The OTA source update remains compatible with stable and dev ESPHome APIs, and no other material behavior change is present. No actionable merge risk is evident. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review details
Pre-merge checks |
|
🤖 Generated with [Claude Code](https://claude.com/claude-code)
5c3f929 to
cdf7e24
Compare
# Conflicts: # Integrations/ESPHome/Core.yaml
Version: 26.10.12.1
What does this implement/fix?
Fixes the build against ESPHome dev. esphome#19211 changed the
http_requestupdate entity'sset_source_url()to take aconst char *and keep the pointer, so passing astd::stringfails withcannot convert 'std::string' to 'const char*'.apply_ota_sourcenow picks between the two manifest URLs as string literals, which stay valid for the life of the firmware. Current stable still accepts this, since itsconst std::string ¶meter converts fromconst char *. No change in behavior.Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code
Summary by CodeRabbit