Skip to content

Fix OTA manifest lambda for ESPHome dev - #27

Merged
TrevorSchirmer merged 3 commits into
betafrom
ota-url-const-char
Oct 12, 2026
Merged

TrevorSchirmer merged 3 commits into
betafrom
ota-url-const-char

Conversation

@bharvey88

@bharvey88 bharvey88 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Version: 26.10.12.1

What does this implement/fix?

Fixes the build against ESPHome dev. esphome#19211 changed the http_request update entity's set_source_url() to take a const char * and keep the pointer, so passing a std::string fails with cannot convert 'std::string' to 'const char*'.

apply_ota_source now picks between the two manifest URLs as string literals, which stay valid for the life of the firmware. Current stable still accepts this, since its const std::string & parameter converts from const char *. No change in behavior.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • Updated the ESPHome integration version to 26.10.12.1.
    • Stable and beta OTA updates continue to use their selected manifest source. The selected source is now logged directly, with no change to the update behavior.

@bharvey88 bharvey88 added the bugfix Something isn't working label Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 824b20ea-b2c7-444d-ad04-20f0f34b0945

📥 Commits

Reviewing files that changed from the base of the PR and between 2aa5702 and d69e6f6.


📒 Files selected for processing (2)
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/H-3.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



Walkthrough

The ESPHome version substitution changes to 26.10.12.1. In apply_ota_source, the selected manifest URL is stored as a const char * and logged directly. Stable and beta selection and the subsequent source URL update remain unchanged.

Changes

ESPHome Version Update

Layer / File(s) Summary
Update configured ESPHome version
Integrations/ESPHome/Core.yaml
The version substitution changes from 26.8.28.1 to 26.10.12.1.

OTA Manifest Logging

Layer / File(s) Summary
Store and log manifest URL
Integrations/ESPHome/H-3.yaml
apply_ota_source stores the selected stable or beta manifest URL as a const char * and logs it directly. The selected URL is still passed to update_http_request.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: bunton33

Merge Risk: ⚪ Minimal · up to d69e6

No material merge-blocking risk is evident in the version update or manifest URL change; the PR is mergeable subject to normal checks.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: fixing the OTA manifest lambda for ESPHome development builds. It is concise and specific.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version bright
Then logs the URL just right
Stable or beta, paths stay true
The update call receives them through
Hop, hop—ESPHome moves anew

Comment @coderabbitai help to get the list of available commands.

@bharvey88
bharvey88 changed the base branch from beta to main September 29, 2026 22:04
@bharvey88 bharvey88 closed this Oct 2, 2026
@TrevorSchirmer
TrevorSchirmer changed the base branch from main to beta October 12, 2026 14:45
@TrevorSchirmer
TrevorSchirmer merged commit b13456c into beta Oct 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants