Repository navigation
Fix OTA manifest lambda for ESPHome dev - #27
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe ESPHome version substitution changes to ChangesESPHome Version Update
OTA Manifest Logging
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No material merge-blocking risk is evident in the version update or manifest URL change; the PR is mergeable subject to normal checks. Pre-merge checks |
|
🤖 Generated with [Claude Code](https://claude.com/claude-code)
fbf8184 to
ac51d35
Compare
# Conflicts: # Integrations/ESPHome/Core.yaml
Version: 26.10.12.1
What does this implement/fix?
Fixes the build against ESPHome dev. esphome#19211 changed the
http_requestupdate entity'sset_source_url()to take aconst char *and keep the pointer, so passing astd::stringfails withcannot convert 'std::string' to 'const char*'.apply_ota_sourcenow picks between the two manifest URLs as string literals, which stay valid for the life of the firmware. Current stable still accepts this, since itsconst std::string ¶meter converts fromconst char *. No change in behavior.Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code
Summary by CodeRabbit