Repository navigation
Conversation
Switch Full Duplex Component
Drop the hard-coded assignee and call the shared Workflows autoassign workflow, which now falls back to the AUTO_ASSIGNEE organization variable. Run on pull_request_target so assignment also works on fork-submitted PRs; the workflow never checks out PR code.
…able Assign issues and PRs via the AUTO_ASSIGNEE org variable
In full duplex the DAC's TX channel is the clock slave, and at the default mclk_multiple of 256 (48 kHz, 32-bit slots) its MCLK/BCLK ratio is 4, below ESP-IDF's minimum of 6. Raise the DAC and ADC to 512. Set min_version to 2026.10.0, which sorts below 2026.10.0b1, so stable builds pass again. Move flash_mode to esp32: and esp32_improv to improv_ble. Bump CI pins, build beta on stable, and drop dev from CI until the 2026.11 switch to the in-tree i2s_audio. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Bunton33
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Full duplex holds the DAC and ADC DMA buffers from boot, so the SPDIF speaker could not allocate its 15 DMA buffers. Vendor the pinned i2s_audio with 8 SPDIF buffers, move Wi-Fi/BSS memory out of internal RAM, and give SPDIF a 2 s timeout so switching back to Analog works. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the audio_http decoder stacks to PSRAM, and have the microphone task wait for internal RAM instead of aborting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ESP-IDF clears the DNS servers whenever any interface restarts DHCP, and an unplugged Ethernet port retries every 15 s, so restore the default interface's servers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Release finished HTTP stream threads, shrink lwIP mailboxes, and move the Line In task stack to PSRAM so announcements work with Line In on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An update check needs about 24 KB of internal RAM, which HA playback on optical can leave short, so checks now wait instead of failing silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
@Bunton33 Need to take a look, I don't think any of the custom components is needed. In the main branch we dropped those and they weren't needed. Are you sure we need to add that all back? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 26.10.26.1
What does this implement/fix?
Fixes loud, distorted analog output: in full duplex the DAC is the I2S clock slave, and at the default
mclk_multipleof 256 ESP-IDF warns its clock ratio is too low, so the DAC and ADC now use 512. Also setsmin_version: 2026.10.0so stable builds pass again, renames deprecated keys, bumps CI pins, and drops dev from CI until 2026.11. Also fixes silent optical output by vendoring the pinnedi2s_audiowith 8 SPDIF DMA buffers, moving some Wi-Fi/BSS memory out of internal RAM, and giving SPDIF a 2 s timeout so switching back to Analog works. Also frees internal RAM so Line In, announcements and update checks no longer crash or fail while HA plays media on optical, and restores the DNS servers that an unplugged Ethernet port wiped every 15 s. Tested on a CAST PRO-1 over Wi-Fi with HA and Music Assistant: analog and optical both sound good, including Line In with optical.Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code