v1.6.19 — star nudge + full hardening pass#10
Merged
Merged
Conversation
…ings Closes the gap between usage and stars: 4k downloads/mo vs ~33 stars because nothing ever asks. After `sipcode proxy --stats` shows real rewrites (totalInvocations > 0), print one line pointing to the repo. Shown ONCE per machine ever, gated on a ~/.sipcode/.star-nudge marker (same pattern as the proxy/install markers). Never in --json mode, never when zero rewrites, never blocks, and makes no network call (privacy guard stays green). New src/lib/starNudge.ts is a pure gate (hasMarker/writeMarker seam); the copy lives in MESSAGES.starNudge. 7 new tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A live star-count badge is self-reinforcing social proof, and a monthly downloads badge shows real adoption (~4k/mo). Both are the highest-ROI README change for converting visitors to stars. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`sipcode today` summarizes all of today's sessions and does not accept --here; only `why` and `stats` register it. Correct the tip that wrongly listed today. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`why --here` / `stats --here` computed the project hash by replacing only `:` and slashes, but Claude Code also turns whitespace into `-` (so "C:\Projects\just research" is stored as "C--Projects-just-research"). The mismatch made --here silently find zero sessions for any path with a space. Extract a single cwdToProjectHash() in discover.ts (now also collapses whitespace) and use it from both why's listSessionsHere and stats, so the two copies can't drift again. 4 new tests pin the encoding. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Two correctness bugs from a full component audit: 1. cwdToProjectHash only collapsed `:/\ + whitespace`, but Claude Code replaces EVERY non-alphanumeric with `-` (verified: ".claude-mem" dir is stored as "--claude-mem"). So --here still mismatched any path with a dot, paren, underscore, etc. Now uses /[^A-Za-z0-9]/g. 2. tsc rewriter appended `2>&1 | head` with no pipefail, so a FAILING typecheck returned head's exit 0 — reporting a broken build as success to Claude. Prepend `set -o pipefail;` so tsc's non-zero status propagates. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ssion From the full component audit, all verified + tested: - today/forecast/trend no longer crash on `--agent auto` (advertised in help) or a typo: route through resolveAgentFromOpts (quiet) like stats, plus the cursor "not supported" message. Was getAgentById(undefined).discoverSessions. - init --no-proxy/--no-marker/--no-verify-mcp/--no-claude-md and receipt --no-share now honored: cli.ts translates Commander's opts.x=false → opts.noX (drift already did this; init/receipt didn't). - proxy cat rewriter no longer matches `type` (a bash builtin that reports command type, not a file reader — awk rewrite changed its meaning). - proxy grep rewriter no longer collapses `grep -rn`/-A/-B/-C/-o to `-c` (which dropped the exact lines/numbers requested); head-caps instead. - impact now skips empty/zero-token sessions like stats/today/forecast/trend. - docs: receipt makes a PNG not a "PDF" (README + llms-full); sample file opus-4-7 → opus-4-8. NOTE: did NOT add pipefail to git/find/ls/grep/npm head-caps — on a successful command with long output, head closing early SIGPIPE-kills it and pipefail would report exit 141 (false failure). Only tsc is safe (success = no output). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The exit-code masking bug wasn't just tsc — every output cap (git, find, ls, grep, npm, tsc) used `cmd | head -N`, so a FAILING command returned head's exit 0 and looked successful to Claude. Naively adding `pipefail` would have made it WORSE: head closes the pipe early, SIGPIPE-killing a SUCCESSFUL long-output command → exit 141 (false failure). Correct fix, in one shared base.capLines(): `set -o pipefail; cmd | awk 'NR<=N'`. awk prints only the first N lines but reads the WHOLE stream, so the command always runs to completion (no SIGPIPE) and pipefail propagates its true exit code. awk is already a proxy dependency (cat rewriter). Trade-off: find/ls/grep can no longer stop early on huge trees (sub-second on a normal repo); correctness wins. All 6 rewriters now route through capLines; 100 rewriter tests updated to the awk form. Full suite 1,387 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
why (no --session) and MCP audit_latest_session picked sessions[0] blindly, so an empty or in-flight latest transcript rendered an all-zero report. Both now scan newest-first and pick the first non-empty session (drift already did this), falling back to the newest if all are empty. Parses lazily, stops at the first hit. Regression test added. This closes the last item from the full component audit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bundles the growth work (one-time star nudge, README social-proof badges) with a complete component-audit hardening batch: proxy exit-code preservation across all output caps, --here full path encoding, today/forecast/trend agent-crash fix, init/receipt --no-* flags, cat/grep rewriter corrections, and consistent empty-session skipping in impact/why/MCP. Bump 1.6.18 -> 1.6.19. CHANGELOG 1.6.19 entry + link ref. README badge, llms.txt / llms-full.txt, landing page, and server.json all -> 1.6.19 / 1,388. Tests: 1,373 -> 1,388, full suite green; privacy + no-shell-args guards green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Anuj7411
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the usage-vs-stars gap (~4k npm downloads/mo vs ~33 stars: people use it, nothing ever asks them to star).
Changes
sipcode proxy --statsshows real rewrites (totalInvocations > 0), print one line pointing to the repo. Shown once per machine ever, gated on a~/.sipcode/.star-nudgemarker (same pattern as the proxy/install markers). Never in--json, never when zero rewrites, never blocks, zero network calls (privacy guard green).src/lib/starNudge.tsis a pure gate (hasMarker/writeMarkerseam); copy lives inMESSAGES.starNudge.Verification
Note: the nudge is mild "ceremony" against the lean-output ethos, but it's one line at a real value moment, consistent with the
▸ next:hints the CLI already prints. Needs a patch release to reach users.🤖 Generated with Claude Code