fix(api): enforce late controller guards - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
No linked issue.
❓ Type of change
📚 Description
Compile handler plans when the first request arrives rather than during route registration. This ensures controller metadata added after route registration, including class-level authorization guards, is present in the compiled plan.
Preserve symbol-keyed computed controller properties by enumerating metadata with
Reflect.ownKeys.Regression tests cover metadata finalized after registration and symbol-keyed computed properties. Real CMS authorization checks with the corrected provider restore owner/member/anonymous outcomes to 200/403/401.
Verification
pnpm lint: passpnpm build: passAmbiguousProviderErrorin Route lifecycle and RateLimit)📝 Checklist