Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Recover and complete the registered-read API foundation. This is not the completed document-owned attachment workflow.
/get?id=..., without inheriting the parent query or changing strict pathname validation.The caller must choose a trusted read target and validate the returned entity; this API does not authorize unrelated objects. Full TLS transport APIs and the live parent connection are not exposed to the child. Parent-disconnect cancellation is not part of this contract.
Verification
pnpm build: pass against the locally packed companion interface.ajs module test . -f dist/test/registered-read.test.js: 38 passing.ajs module test . -f dist/test/controller-resolution.test.js: 9 passing, including the sparse-parameter regression.pnpm dlx @antelopejs/core@1.5.1 module test .: 215 passing, 1 failing. The same callback-identity assertion in the interface dependency fails on unmodifiedorigin/mainwith the identical interface archive: 176 passing, 1 failing.pnpm lint,pnpm format:check,pnpm knip,git diff --check: pass, with existing warnings/configuration hints.Merge blocker: unpublished dependency
Depends on AntelopeJS/interface-api#20.
The optional
@antelopejs/interface-api/registered-readexport is not published yet. The committed dependency range and frozen lockfile still select the old interface, so a clean CI build is expected to fail until the companion interface PR is merged and released, then this PR's dependency floor and lockfile are updated.Local tarball paths were used only for validation and are not committed. Keep this PR in draft; do not merge, publish or deploy it as a standalone change.