Skip to content

Add terminal history fallback for macOS terminal apps - #85

Merged
ncoop57 merged 1 commit into
mainfrom
feat/macos-term-history
Jun 1, 2026
Merged

Add terminal history fallback for macOS terminal apps#85
ncoop57 merged 1 commit into
mainfrom
feat/macos-term-history

Conversation

@PiotrCzapla

Copy link
Copy Markdown
Contributor

I often find myself not using tmux locally, and then I end up going to ChatGPT for advice instead of shell_sage.
So I thought that adding support for macOS Terminal and iTerm might be a good addition, especially since it's a small change that only kicks in when sage is being used from a supported terminal.
Screenshot 2026-05-11 at 14 27 58

@vedang

vedang commented May 12, 2026

Copy link
Copy Markdown

I just implemented this right now for shell_sage + ghostty :) I checked 2 days ago and this did not exist in the codebase then.

@PiotrCzapla
PiotrCzapla requested a review from ncoop57 May 13, 2026 05:51
@PiotrCzapla
PiotrCzapla force-pushed the feat/macos-term-history branch from 615edf9 to 7114d4b Compare June 1, 2026 09:25
@PiotrCzapla

Copy link
Copy Markdown
Contributor Author

I just implemented this right now for shell_sage + ghostty :) I checked 2 days ago and this did not exist in the codebase then.

Cool, I've updated the branch so it can be cleanly merge. Do you want to add a PR? Does it work in solveit's terminal tab it uses ghostty?

@ncoop57 ncoop57 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, didn't realize it was so easy. Thanks!

@ncoop57
ncoop57 merged commit 52a3363 into main Jun 1, 2026
@ncoop57

ncoop57 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@vedang would appreciate a PR 🙏🏻

@vedang

vedang commented Jun 16, 2026

Copy link
Copy Markdown

Sorry, I totally missed these notifications. I will rebase on top of the latest master and submit a PR today.

@vedang

vedang commented Jul 27, 2026

Copy link
Copy Markdown

Sorry for the delay folks. Here you go: #95 . I rebased it on top of the latest main.

I've been using it for a while on Ghostty, works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants