Skip to content

fix: removing redundant exception argument causing faulty error tracking - #59

Open
jakobSCHn wants to merge 1 commit into
AmbiqAI:mainfrom
jakobSCHn:fix/fswpa14-calc-errormsg
Open

jakobSCHn wants to merge 1 commit into
AmbiqAI:mainfrom
jakobSCHn:fix/fswpa14-calc-errormsg

Conversation

@jakobSCHn

Copy link
Copy Markdown

Summary

Fixes an issue in feature calculation error handling where passing an explicit exception argument to logger.exception() caused formatting clashes and masked the actual stack trace.

Details & Motivation

  • The Issue: logger.exception() automatically captures and appends the active stack trace. Passing the explicit err argument alongside an evaluated f-string was redundant. This resulted in formatting errors, hiding the real underlying functional error.
  • The Fix: Removed the redundant err argument from the logger call.
  • The Impact: Ensures proper error tracking by allowing the logging module to correctly surface the actual exception and stack trace occurring during feature computation, rather than failing on string formatting.

How to Test

  1. Trigger a feature calculation error on this branch.
  2. Verify the log output cleanly displays the full python stack trace without formatting errors.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant