chore(skills): promote skills/ to a first-class repo-root directory - #579
Merged
Conversation
Move ship and ship-phase out of .claude/skills into a new root-level skills/ directory, and symlink .claude/skills, .agents/skills, and .codex/skills to it so Claude Code, the Codex CLI, and generic agent tooling share one source of truth instead of three copies. Also vendor the sql-browser-dashboard skill: it turns an already-known SQL/result-column investigation into a validated PortableBundleV2 Dashboard bundle and publishes it through the save_dashboard MCP tool (or leaves it as a downloadable JSON file when that tool isn't wired up). Verified its authoring profile field-for-field against this repo's real schemas/*.json — no drift found. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L3pqYYJrP8zAmLmrJvzcxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shipandship-phaseout of.claude/skillsinto a new root-levelskills/directory, so it's one shared source of truth instead of being nested under a single tool's dotfolder..claude/skills,.agents/skills, and.codex/skills(new) to../skillsso Claude Code, generic agent tooling, and the Codex CLI all resolve the same files..gitignorefor the new layout: the vendoredimpeccableskill's ignore rule now targets/skills/impeccable/, and the old per-item.agents/skills/*negation pattern is gone (replaced by one shared symlink instead of two per-skill ones).sql-browser-dashboardskill (vendored from a local review copy): turns an already-known SQL/result-column investigation into a validatedPortableBundleV2Dashboard bundle and publishes it via thesave_dashboardMCP tool, or leaves the bundle as a downloadable JSON file when that tool isn't wired up in a given deployment.skills/ship/{SKILL.md,references/unattended.md,references/per-issue-cycle.md}that was sitting uncommitted, adding achatgpt-review-skill-based third-party review step to/ship(steps 7-8). Note: nochatgpt-reviewskill currently exists in this repo — this step will no-op/error until that skill is added separately.Review of the vendored skill
Verified
sql-browser-dashboard's authoring profile field-for-field against this repo's real schemas (schemas/portable-bundle-v2.schema.json,dashboard-v2.schema.json,dashboard-layout-flow-v1.schema.json,saved-query-v2.schema.json,query-spec-v1.schema.json): bundle/dashboard/layout formats, the panel type enum (bar/hbar/line/area/pie/kpi/table/logs/text), andfieldConfigfields all match exactly — no invented fields or fabricated panel types found. Its ownscripts/validate_bundle.pypasses cleanly against its ownreferences/example-dashboard.json. Thesave_dashboardMCP write path it targets is real prior art (matching infra exists in a siblingbentoclickrepo) and is correctly scoped as external/deployment-specific rather than assumed to be wired up in this repo.Test plan
npm run check:schemas && npm run check:examples && npm run check:arch— passnpm run check:types/npm test— could not run in this environment:node_modules/.bin/*symlinks are unreadable here (pre-existing environment permission issue, unrelated to this change — this PR touches no source, test, or build config, onlyskills/,.gitignore, and the three tool-convention symlinks).claude/skills,.agents/skills,.codex/skills) resolve toship,ship-phase,sql-browser-dashboardskills/impeccable/is still correctly gitignored under the new layout🤖 Generated with Claude Code
https://claude.ai/code/session_01L3pqYYJrP8zAmLmrJvzcxx