TTL Export 2.0#1848
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71b91813bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (metadata.table_ttl.export_ttl.empty()) | ||
| { | ||
| /// EXPORT TTL relies on the ALTER ... EXPORT PARTITION pipeline, which is only | ||
| /// available for Replicated*MergeTree. | ||
| if (!replicated) | ||
| { | ||
| throw Exception(ErrorCodes::NOT_IMPLEMENTED, | ||
| "TTL EXPORT is only supported for Replicated*MergeTree, got {}", args.engine_name); |
There was a problem hiding this comment.
This condition is inverted: for any normal table TTL such as TTL d + INTERVAL 1 DAY DELETE, metadata.table_ttl.export_ttl is empty, so every non-replicated MergeTree table with an ordinary TTL now throws TTL EXPORT is only supported for Replicated*MergeTree. The Replicated*MergeTree/partition-key restriction should only run when an EXPORT TTL is actually present.
Useful? React with 👍 / 👎.
1 participant
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
TTL Export, tbd
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: