Conversation
Add ISmtp2GoClient.SendMimeAsync, which POSTs a pre-built RFC 5322 message to the SMTP2GO email/mime endpoint. Unlike email/send (which reconstructs the MIME from structured fields), email/mime transmits the supplied message verbatim, preserving the caller's Content-Type (e.g. multipart/alternative) and Message-ID. The request body is a single base64 mime_email field; the response envelope matches email/send. - EmailMimeRequest model (snake_case mime_email) - SendMimeAsync on ISmtp2GoClient + Smtp2GoClient (+ MimeSendStarted log) - Unit tests: EmailMimeRequest serialization + client SendMimeAsync behavior (mocked transport, posts to email/mime, error mapping) - Integration tests: email/mime sandbox + live, proven against the real API (RawMimeBuilder hand-builds a multipart/alternative message, since the SDK takes the MIME as an opaque base64 string) - Bump version 1.2.0 -> 1.3.0
SMTP2GO now validates that a webhook URL points to a reachable destination at webhook/add time (HTTP 400 "The passed URL must point to a valid destination"), so the webhook-management CRUD tests that registered a fake example.com URL began failing in CI. Webhook *creation* now has the same reachable-endpoint requirement that already excludes the *delivery* tests. - Extract the receiver+tunnel setup into a shared WebhookPipelineHelper (EstablishReachableWebhookUrlAsync + webhook cleanup), used by both the delivery and management test classes instead of duplicating the pipeline. - Point the management CRUD tests at a real Cloudflare-tunnel-backed receiver URL so they pass when run locally, and retag them Integration.Webhook so the existing CI exclusion (-trait- Category=Integration.Webhook) skips them. - Update CI.yml comments: webhook delivery AND management are excluded. Email/send, email/mime, and stats live/sandbox tests remain in CI (15 tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.