Repository navigation
refactor: check DocDB v1 names against v2 - #65
Merged
Merged
Conversation
seanmcculloch
force-pushed
the
record-consistency-v1-coverage
branch
2 times, most recently
from
October 1, 2026 17:31
2a99d7f to
443dd7a
Compare
seanmcculloch
added this pull request to stack #67
October 1, 2026 17:31
seanmcculloch
force-pushed
the
record-consistency-v1-coverage
branch
2 times, most recently
from
October 1, 2026 18:23
9e641f5 to
5f431c6
Compare
seanmcculloch
marked this pull request as ready for review
October 1, 2026 18:53
seanmcculloch
changed the title
dbirman
force-pushed
the
record-consistency-v1-coverage
branch
2 times, most recently
from
October 7, 2026 05:28
68396ca to
8cebd6f
Compare
seanmcculloch
force-pushed
the
record-consistency-v1-coverage
branch
from
October 13, 2026 22:39
8cebd6f to
1fd319e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add a
docdb_v1source and a check that fails v1 records with no exact name match in v2. The source sweeps v1 by_idand refetches only records whoselast_modifiedchanged since the previous snapshot.Review notes
Matched in time, the failures overlap almost entirely with
metadata_upgrade's not-upgraded rows. Keep it, re-source it from that table, or drop it?